commit 55cb37f064fc32998a035e78d41f3aa852270642 Author: Alan Coopersmith Date: Thu Apr 4 17:00:32 2024 -0700 xdm 1.1.16 Signed-off-by: Alan Coopersmith commit 2b451b9915e3a379974a3c2b5fe9d4798f0c136b Author: Alan Coopersmith Date: Mon Mar 25 13:06:28 2024 -0700 Define _CONST_X_STRING when including Xaw & Xt headers Fixes build when building against libXaw 1.0.16 since xorg/lib/libxaw@d0fcbd97 changed the definition of XawListChange in from _Xconst char * to String *, where String is defined as const if _CONST_X_STRING is defined. This also clears up 105 of the 162 -Wdiscarded-qualifiers warnings. Closes: #16 Fixes: bccb777 ("Fix -Wincompatible-pointer-types warning from gcc (issue #15)") Signed-off-by: Alan Coopersmith commit 1a408d7f74618d28db6ec4ec377ab479bd8f75aa Author: Alan Coopersmith Date: Sat Mar 23 15:15:52 2024 -0700 xdm 1.1.15 Signed-off-by: Alan Coopersmith commit 634f47a8aec386b7dedb8f716a65a9b56c0d7de7 Author: Alan Coopersmith Date: Sun Feb 11 11:27:55 2024 -0800 session.c: clear -Wredundant-decls warnings on Solaris Include standard headers for getpwnam() & crypt() instead of local prototype redefinitions. Signed-off-by: Alan Coopersmith commit 2693b540f90e1a79c277bac7ec9fa5e40d05a281 Author: Alan Coopersmith Date: Sun Feb 11 11:22:21 2024 -0800 unifdef __osf__ Signed-off-by: Alan Coopersmith commit c8af3994d76bc5cc3ee8443c1ee366353daea840 Author: Alan Coopersmith Date: Sun Feb 11 11:12:15 2024 -0800 include on all platforms with HAVE_GETSPNAM set, not just SVR4 Matches what we already do in greeter/verify.c Signed-off-by: Alan Coopersmith commit 7e8a581cda4aaac7e1d6af3d0000a0d03816adc3 Author: Alan Coopersmith Date: Sun Feb 11 11:02:38 2024 -0800 Remove support for SVR4 systems other than Solaris/illumos Signed-off-by: Alan Coopersmith commit 387bcf8bad11196967943a3352b9eb0d0f1f897e Author: Alan Coopersmith Date: Sun Feb 11 10:47:13 2024 -0800 unifdef FRAGILE_DEV_MEM It was only defined in the old Imakefiles, and not in any autoconf config Signed-off-by: Alan Coopersmith commit c31f9dcc8055fdf6b5ff2cc59fef89e1cf09a0ab Author: Alan Coopersmith Date: Sun Feb 11 10:44:17 2024 -0800 unifdef UNRELIABLE_SIGNALS UNRELIABLE_SIGNALS was only defined if SYSV was defined Signed-off-by: Alan Coopersmith commit 48ad0d9b915f858fda2b005d4e7f01ca465a51f9 Author: Alan Coopersmith Date: Sun Feb 11 10:42:24 2024 -0800 unifdef SIGNALS_RESET_WHEN_CAUGHT SIGNALS_RESET_WHEN_CAUGHT was only defined if SYSV was defined Signed-off-by: Alan Coopersmith commit 8a9a4e5be8d4906aa7b1365140445db33e6cbbbd Author: Alan Coopersmith Date: Sun Feb 11 10:41:09 2024 -0800 unifdef SYSV Signed-off-by: Alan Coopersmith commit ae942bf8aba373f3d7db6af868e0f8154fdd23f2 Author: Alan Coopersmith Date: Sun Feb 11 10:35:12 2024 -0800 unifdef AF_DECnet Signed-off-by: Alan Coopersmith commit 493673ef4914f56c8ee471b88f16b02e468f9c3b Author: Alan Coopersmith Date: Sun Feb 11 10:34:22 2024 -0800 unifdef AF_CHAOS Signed-off-by: Alan Coopersmith commit 37f80c7716759ed066af68011a35459706e70262 Author: Alan Coopersmith Date: Sun Feb 11 10:26:05 2024 -0800 unifdef QNX4 Signed-off-by: Alan Coopersmith commit ee19d5f4352135a9044a238112738dc66ec50b46 Author: Alan Coopersmith Date: Sun Feb 11 10:17:35 2024 -0800 unifdef __UNIXOS2__ Signed-off-by: Alan Coopersmith commit 2956192801a3e85136d54277409c2ebdea15b3be Author: Alan Coopersmith Date: Sun Feb 11 10:13:04 2024 -0800 unifdef pegasus Signed-off-by: Alan Coopersmith commit 279dba5bed1706ddce0164f78c32a81389b85909 Author: Alan Coopersmith Date: Sun Feb 11 10:08:32 2024 -0800 unifdef hpux Signed-off-by: Alan Coopersmith commit 52578f77a14808b7d8925b3ee309d5ceac674b22 Author: Alan Coopersmith Date: Sun Feb 11 10:02:29 2024 -0800 unifdef __convex__ Signed-off-by: Alan Coopersmith commit 1fe9ab1cbf7f0a1684b1f1e53f1a6816916bb3fa Author: Alan Coopersmith Date: Sun Feb 11 09:58:51 2024 -0800 unifdef PowerMAX_OS Signed-off-by: Alan Coopersmith commit 9660da78eac0da9ff951ddf0367ad0d09eca885f Author: Alan Coopersmith Date: Sun Feb 11 09:55:27 2024 -0800 unifdef sony Signed-off-by: Alan Coopersmith commit 0c49eecefffc16d5ea30709e7901bcdd41136a7c Author: Alan Coopersmith Date: Sun Feb 11 09:51:03 2024 -0800 unifdef ultrix Signed-off-by: Alan Coopersmith commit 86e227cdfdb9d2454571aa2eb63c81bca139552e Author: Alisson Bruno Date: Sun Feb 11 16:56:55 2024 +0000 Fix --with-systemd-daemon option commit 9602a9f11dd5ac928a7275ceb1a58d5328b9d49e Author: Alan Coopersmith Date: Thu Feb 1 18:16:59 2024 -0800 greeter: Constify value argument to SetValue() Signed-off-by: Alan Coopersmith commit 3672840c24e0826b7305d5143c95b2d070c57366 Author: Alan Coopersmith Date: Thu Feb 1 18:14:56 2024 -0800 greeter: Handle const qualification differences between Solaris & Linux PAM Solaris does not specify "const" on the first argument to PAM conversation functions, nor the third argument to pam_get_item(). Linux PAM does both. Signed-off-by: Alan Coopersmith commit bccb77746528134aa2e865ca4f44fd9424738b3f Author: Alan Coopersmith Date: Tue Dec 5 17:25:28 2023 -0800 Fix -Wincompatible-pointer-types warning from gcc (issue #15) chooser.c:280:26: warning: passing argument 2 of ‘XawListChange’ from incompatible pointer type [-Wincompatible-pointer-types] 280 | XawListChange (list, newTable, size, 0, TRUE); | ^~~~~~~~ | | | char ** In file included from chooser.c:59: /usr/include/X11/Xaw/List.h:170:27: note: expected ‘const char **’ but argument is of type ‘char **’ 170 | _Xconst char **list, Closes: #15 Signed-off-by: Alan Coopersmith commit b2569e49dda3f15b9cbf8df60c86bee9ed01a40a Author: Alan Coopersmith Date: Sat Dec 2 10:58:23 2023 -0800 configure: Use LT_INIT from libtool 2 instead of deprecated AC_PROG_LIBTOOL AC_PROG_LIBTOOL was replaced by LT_INIT in libtool 2 in 2008, so it's time to rely on it. Clears autoconf warnings: configure.ac:37: warning: The macro 'AC_LIBTOOL_DLOPEN' is obsolete. configure.ac:37: You should run autoupdate. m4/ltoptions.m4:113: AC_LIBTOOL_DLOPEN is expanded from... configure.ac:37: the top level configure.ac:37: warning: AC_LIBTOOL_DLOPEN: Remove this warning and the call to _LT_SET_OPTION when you configure.ac:37: put the 'dlopen' option into LT_INIT's first parameter. ./lib/autoconf/general.m4:2434: AC_DIAGNOSE is expanded from... m4/ltoptions.m4:113: AC_LIBTOOL_DLOPEN is expanded from... configure.ac:37: the top level configure.ac:38: warning: The macro 'AC_PROG_LIBTOOL' is obsolete. configure.ac:38: You should run autoupdate. m4/libtool.m4:100: AC_PROG_LIBTOOL is expanded from... configure.ac:38: the top level Signed-off-by: Alan Coopersmith commit b378b79ce9ae1036fc3d3865186eddf0a56112db Author: Alan Coopersmith Date: Fri Oct 13 15:18:27 2023 -0700 gitlab CI: Update to latest CI templates & Debian stable release Current template fails to rebuild the CI container with the current Debian stable release (a new release since the last update) Signed-off-by: Alan Coopersmith commit d2efd22bd2cbee6a04da0bcaec35d03890522dcc Author: Alan Coopersmith Date: Sat Feb 25 08:58:08 2023 -0800 Remove "All rights reserved" from Oracle copyright notices Oracle no longer includes this term in our copyright & license notices. Signed-off-by: Alan Coopersmith commit 0a94a0a23880e1f6aae6f603d5aab7f7f4df7504 Author: Alan Coopersmith Date: Thu Jul 28 17:30:21 2022 -0700 gitlab CI: stop requiring Signed-off-by in commits Signed-off-by: Alan Coopersmith commit 022b959f5f26e6b70d2ab6524ca39b5934e4c42e Author: Alan Coopersmith Date: Sat Dec 3 13:34:29 2022 -0800 xdm 1.1.14 Signed-off-by: Alan Coopersmith commit 968b9c0b390f15f44ab4f3ee5fce23a9cec60720 Author: Alan Coopersmith Date: Sat Nov 5 10:37:33 2022 -0700 Only link with libbsd if needed for arc4random() or setproctitle() Avoid unnecessary library dependency when using a libc with these functions included. Also only links to the binary that needs them (xdm, not chooser or greeter) Signed-off-by: Alan Coopersmith commit 8a10c98d29d0ff2028f109b5671dfae2910df051 Author: Guillem Jover Date: Thu Oct 6 00:11:18 2022 +0000 Switch from libbsd to libbsd-overlay This is the preferred usage form for libbsd, as it makes the code more portable and requires no special includes for libbsd, by transparently injects the needed standard headers that would be used on a BSD. Signed-off-by: Guillem Jover commit 468b76023a2dfb750c4d5e9b184f230c5b6ec670 Author: Callum Farmer Date: Sun Sep 11 12:57:05 2022 +0100 genauth: fix build with arc4random in glibc 2.36 HAVE_ARC4RANDOM is defined under glibc 2.36 but this will attempt to include from libbsd instead of from glibc Signed-off-by: Callum Farmer commit 0f46b67b45ef40854ad7924e836134bf3f920e09 Author: Alan Coopersmith Date: Sat Apr 30 11:59:31 2022 -0700 chooser: avoid free of uninitialized pointer in allocation failure cleanup Resolves issue found by Oracle Parfait static analyzer: Error: Uninitialised memory Uninitialised memory [uninitialised-mem] (CWE 456): Possible access to uninitialised memory referenced by 'new->fullname' Memory 'new->fullname' accessed at byte offset '8' at line 357 of app/xdm/chooser/chooser.c in function 'AddHostname'. Write does not overlap at line 355 new allocated at line 329 Signed-off-by: Alan Coopersmith commit 3544fa9ec2e17e481785382317ef93ec2ac32ddf Author: Alan Coopersmith Date: Sun Apr 10 11:58:38 2022 -0700 Use memcpy() instead of memmove() when buffers are known not to overlap Most of these came from a mass bcopy() -> memmove() substitution in 1993 with a commit comment of "ANSIfied for R6". Signed-off-by: Alan Coopersmith commit f01b28cf76d641881fa1c5bf7f9dd2487b9ced6b Author: Alan Coopersmith Date: Sun Apr 10 11:33:38 2022 -0700 all_query_respond(): handle ConvertAddr failure sooner Don't try to process returned data values that may not be set Resolves Oracle Parfait issue: Error: Uninitialised memory Uninitialised memory variable [uninitialised-mem-var] (CWE 457): Possible access to uninitialised memory referenced by variable 'length' at line 238 of xdm/xdmcp.c in function 'all_query_respond'. Path in callee avoiding write at line 237 length allocated at line 231 Signed-off-by: Alan Coopersmith commit 00e0b3ae11bb1d4681b0206c341f57fc46ea98b1 Author: Alan Coopersmith Date: Sun Apr 10 11:14:50 2022 -0700 GetChooserAddr(): verify socket address fit in provided buffer Should never happen, but makes Oracle Parfait stop warning: Error: Buffer overrun Read Outside Array Bounds in STD C function [read-outside-array-bounds-call-stdc]: Read outside array bounds in call to memmove. Buffer ((int8*)&in_addr) of size 256 is read at an offset of len Array size is 256 bytes, index <= 1024 at line 130 of xdm/socket.c in function 'GetChooserAddr'. called at line 197 of xdm/choose.c in function 'FormatChooserArgument' with lenp = &addr_len. Signed-off-by: Alan Coopersmith commit c7daccd105a74fe97adb2c8e2842e3b19d5dd34c Author: Matt Turner Date: Sun Apr 10 12:40:13 2022 -0700 configure.ac: Add option to disable Xinerama Bug: https://bugs.gentoo.org/384371 Signed-off-by: Matt Turner commit df5bb7f4e4039192571de75179658ee9c2ee58eb Author: Alan Coopersmith Date: Sun Apr 3 14:42:16 2022 -0700 xdm 1.1.13 Signed-off-by: Alan Coopersmith commit d0fa51471049d427b95346dd7ffc17ff9c17b1d9 Author: Alan Coopersmith Date: Sat Dec 4 11:46:06 2021 -0800 Build xz tarballs instead of bzip2 Signed-off-by: Alan Coopersmith commit 943f2aa19005c53ee5c7c0782af382948e689af1 Author: Alan Coopersmith Date: Sat Dec 4 11:46:02 2021 -0800 gitlab CI: add a basic build test Signed-off-by: Alan Coopersmith commit c84d3f77abdb5502140ba36137c25a6dd07df756 Author: Alan Coopersmith Date: Sun Nov 1 10:20:02 2020 -0800 doneAddrs: reset addrs to NULL after freeing list Resolves warning from Oracle Parfait static analyzer: Warning: Dangling pointer Dangling pointer [dangling-pointer]: Invalid pointer is accessible to caller via global addrs at line 664 of xdm/auth.c in function 'doneAddrs'. Invalid pointer accessible via global addrs at line 646 a accessed from addrs at line 658 in function 'doneAddrs' a freed with free at line 662 Signed-off-by: Alan Coopersmith commit 9505d391c72c90635453cc160b6f64e02da6a318 Author: Alan Coopersmith Date: Sun Nov 1 10:05:11 2020 -0800 Greeter: add parens to DRAW_STRING & TEXT_WIDTH macros for safety Oracle Parfait static analyser points out it wasn't clear if cast or arithmetic operation in arguments at lines 410, 416, 431, & 433 was intended to be done first, so we'll make it explicit. Signed-off-by: Alan Coopersmith commit 529ff7c9591e58c6003d7b330a80adf63fa5b736 Author: Matt Turner Date: Wed Oct 28 21:15:14 2020 -0400 configure.ac: Link with libsystemd, not libsystemd-daemon libsystemd-daemon was merged into libsystemd in 2014, for systemd-209. Fixes: https://gitlab.freedesktop.org/xorg/app/xdm/-/issues/9 Signed-off-by: Matt Turner commit 945a3a05e53ddd32578d5146ec4943fe9297aba4 Author: Alan Coopersmith Date: Tue Jul 21 19:04:11 2020 -0700 Fix spelling/wording issues Found by using: codespell --builtin clear,rare,usage,informal,code,names Signed-off-by: Alan Coopersmith commit a03a628e2adeac10aa0fc494a5f04f25e3b31d7e Author: Alan Coopersmith Date: Sat Mar 2 14:02:19 2019 -0800 xdm 1.1.12 Signed-off-by: Alan Coopersmith commit 5f941a815b7bad49a766987660094b01046c8e7d Author: Alan Coopersmith Date: Mon Feb 25 14:22:27 2019 -0800 Use sed instead of the C pre-processor to generate config files Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=93359 while avoiding https://bugs.freedesktop.org/show_bug.cgi?id=107368 Signed-off-by: Alan Coopersmith commit dd7402c2f1e828cc3b0fae036b62f74b8014814b Author: David Carlier Date: Wed May 4 17:46:15 2016 +0100 fix length format in StartClient() debug message changing the printf-like format as strlen returns an unsigned type Reviewed-by: Alan Coopersmith Signed-off-by: Alan Coopersmith commit 42ae3d66283a9efa0c510d5d438f821549656fe6 Author: David Carlier Date: Wed May 4 17:46:15 2016 +0100 fix memory leak in StorePid() Reviewed-by: Alan Coopersmith Signed-off-by: Alan Coopersmith commit 7a56946260616f7f5ff43ecbaac1f2ada9b0afcd Author: Chí-Thanh Christopher Nguyễn Date: Mon Jan 6 15:52:47 2014 +0000 xdm uses setproctitle without proper includes for Linux libbsd Signed-off-by: Alan Coopersmith commit 786b2c7ed39fb0cdd4c34e51f5c58f980087dcc1 Author: Chí-Thanh Christopher Nguyễn Date: Mon Jan 6 15:52:00 2014 +0000 xdm uses arc4random without proper includes for Linux libbsd Signed-off-by: Alan Coopersmith commit 16d74befa4430eb024d81ee4070520afff697d60 Author: Alan Coopersmith Date: Wed Nov 21 17:01:20 2018 -0800 Update configure.ac bug URL for gitlab migration Signed-off-by: Alan Coopersmith commit a7623a6555689cb3d1acfc66c0562985b106a85b Author: Alan Coopersmith Date: Fri Nov 16 21:30:06 2018 -0800 Update README for gitlab migration Signed-off-by: Alan Coopersmith commit 768a8c524642955527066ba90be6ffd511e30ed5 Author: Björn Esser Date: Thu Aug 16 15:42:34 2018 -0400 glibc: Include if needed, fix build with 2.28 Signed-off-by: Adam Jackson commit b6853380678b793bad81ac09b2f872f8225ccec6 Author: Alan Coopersmith Date: Sat May 5 12:28:27 2018 -0700 Add missing brackets to multi-statement if in SaveServerAuthorizations Introduced by commit 5222d28e8d8e5b4cc Reported by gcc 7.3: auth.c: In function ‘SaveServerAuthorizations’: auth.c:447:6: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] if (auths[i]->data_length > 0) ^~ auth.c:452:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’ (void) fflush (auth_file); ^ Signed-off-by: Alan Coopersmith Reviewed-by: Matthieu Herrb commit 50bd014ad8ed0b0af1e9e8130779acd0473a6899 Author: Matthieu Herrb Date: Sun Oct 1 09:43:53 2017 +0200 chown before chmod This prevents a malicious user logging out from calling chmod while still owning /dev/console and thus by-passing the '622' mode that is set here. Issue reported by Tim Chase. Thanks. Reviewed-by: Alan Coopersmith commit 4743378ccf1defe5984ad71797283b98029aa920 Author: Alan Coopersmith Date: Mon Jan 16 16:21:37 2017 -0800 Install xdm man pages under admin section (8), not user programs (1) As best I can tell, it was historically under section 1 mainly because the old X Consortium Imake configs only supported installing program man pages there, and didn't have an option for using other sections. Signed-off-by: Alan Coopersmith Reviewed-by: Peter Hutterer commit 53a781392bdd785db8a12572a7323de35a16d896 Author: Mihail Konev Date: Thu Jan 26 14:00:21 2017 +1000 autogen: add default patch prefix Signed-off-by: Mihail Konev commit 6004d4b43e76522528cb93f56b38f4f5130d4e1f Author: Emil Velikov Date: Mon Mar 9 12:00:52 2015 +0000 autogen.sh: use quoted string variables Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent fall-outs, when they contain space. Signed-off-by: Emil Velikov Reviewed-by: Peter Hutterer Signed-off-by: Peter Hutterer commit 62e239d1ea3294239830f39ac8e4d21b6b17ec8d Author: Peter Hutterer Date: Tue Jan 24 10:32:07 2017 +1000 autogen.sh: use exec instead of waiting for configure to finish Syncs the invocation of configure with the one from the server. Signed-off-by: Peter Hutterer Reviewed-by: Emil Velikov commit 02c5858734585795f53b90a245afafb3c606c5ce Author: Alan Coopersmith Date: Thu Jan 28 09:02:06 2016 -0800 Remove non-existent cpp resource from man page From what I can see in the ancient X Consortium archives, the cpp resource was added in X11R4 and documented but never actually used, and removed in X11R5 without remembering to remove it from the man page. Reported-by: John Smith Signed-off-by: Alan Coopersmith Reviewed-by: Matthieu Herrb Signed-off-by: Peter Hutterer commit 994d32ad92e12aa381f222db68db9997a602197e Author: Matthieu Herrb Date: Tue Jan 5 21:31:12 2016 +0100 Missed on arc4random() conversion. Signed-off-by: Matthieu Herrb Reviewed-by: Alan Coopersmith commit 5defb9365b7bfb758024ed203b30ee245285b77f Author: Matthieu Herrb Date: Mon Oct 26 17:09:53 2015 +0100 Unifdef X_NO_SYS_UN Nothing has set that since the modularization Signed-off-by: Matthieu Herrb Reviewed-by: Adam Jackson Reviewed-by: Alan Coopersmith commit 720378013765a5bad7bddbb775aa6845c6d9c4af Author: Matthieu Herrb Date: Mon Oct 26 16:59:09 2015 +0100 Remove AIXV3, SCO, Unixware, OS/2 support Signed-off-by: Matthieu Herrb Reviewed-by: Adam Jackson Reviewed-by: Alan Coopersmith commit 82298bc7aa1b1715adce9de1cf61c6335bc659d8 Author: Matthieu Herrb Date: Tue Dec 1 19:15:50 2015 +0100 Remove #if 0'd code Signed-off-by: Matthieu Herrb Reviewed-by: Adam Jackson Reviewed-by: Alan Coopersmith commit c0c3ad0cc5a6e5cf528245fb7f4e47b91163333c Author: Jeremy Huddleston Sequoia Date: Sun Oct 18 22:35:00 2015 -0700 Fixup various format warnings in PrintProtoDisplay protodpy.c:52:35: warning: format specifies type 'unsigned int' but the argument has type 'struct protoDisplay *' [-Wformat] Debug ("ProtoDisplay 0x%x\n", pdpy); ~~ ^~~~ protodpy.c:54:20: warning: incompatible pointer types passing 'XdmcpNetaddr' (aka 'char *') to parameter of type 'struct sockaddr *' [-Wincompatible-pointer-types] PrintSockAddr (pdpy->address, pdpy->addrlen); ^~~~~~~~~~~~~ ../include/dm_socket.h:46:45: note: passing argument to parameter 'a' here extern void PrintSockAddr (struct sockaddr *a, int len); ^ protodpy.c:55:41: warning: format specifies type 'int' but the argument has type 'unsigned long' [-Wformat] Debug ("\tdate %d (%d from now)\n", pdpy->date, time(0) - pdpy->date); ~~ ^~~~~~~~~~ %lu protodpy.c:55:53: warning: format specifies type 'int' but the argument has type 'unsigned long' [-Wformat] Debug ("\tdate %d (%d from now)\n", pdpy->date, time(0) - pdpy->date); ~~ ^~~~~~~~~~~~~~~~~~~~ %lu protodpy.c:57:32: warning: format specifies type 'int' but the argument has type 'CARD32' (aka 'unsigned long') [-Wformat] Debug ("\tsessionID %d\n", pdpy->sessionID); ~~ ^~~~~~~~~~~~~~~ %lu Signed-off-by: Jeremy Huddleston Sequoia commit d5aa455a2575fca74219bb567ae4cb8c63a8401d Author: Jeremy Huddleston Sequoia Date: Sun Oct 18 22:21:05 2015 -0700 Silence -Wmissing-noreturn warnings choose.c:463:1: warning: function 'RunChooser' could be declared with attribute 'noreturn' [-Wmissing-noreturn] chooser.c:1062:1: warning: function 'DoCancel' could be declared with attribute 'noreturn' [-Wmissing-noreturn] reset.c:81:1: warning: function 'abortReset' could be declared with attribute 'noreturn' [-Wmissing-noreturn] server.c:154:1: warning: function 'serverPauseAbort' could be declared with attribute 'noreturn' [-Wmissing-noreturn] server.c:161:1: warning: function 'serverPauseUsr1' could be declared with attribute 'noreturn' [-Wmissing-noreturn] server.c:236:1: warning: function 'abortOpen' could be declared with attribute 'noreturn' [-Wmissing-noreturn] server.c:329:1: warning: function 'PingLost' could be declared with attribute 'noreturn' [-Wmissing-noreturn] server.c:348:1: warning: function 'PingLostSig' could be declared with attribute 'noreturn' [-Wmissing-noreturn] session.c:231:1: warning: function 'catchTerm' could be declared with attribute 'noreturn' [-Wmissing-noreturn] session.c:293:1: warning: function 'SessionPingFailed' could be declared with attribute 'noreturn' [-Wmissing-noreturn] session.c:240:1: warning: function 'catchAlrm' could be declared with attribute 'noreturn' [-Wmissing-noreturn] session.c:249:1: warning: function 'waitAbort' could be declared with attribute 'noreturn' [-Wmissing-noreturn] session.c:330:1: warning: function 'ManageSession' could be declared with attribute 'noreturn' [-Wmissing-noreturn] session.c:471:1: warning: function 'syncTimeout' could be declared with attribute 'noreturn' [-Wmissing-noreturn] session.c:519:1: warning: function 'SessionExit' could be declared with attribute 'noreturn' [-Wmissing-noreturn] Signed-off-by: Jeremy Huddleston Sequoia commit 6cc5153d77f9f48b8dd16e17e48eac4d6ef13929 Author: Jeremy Huddleston Sequoia Date: Sun Oct 18 22:13:31 2015 -0700 Add missing prototype for PrintSockAddr protodpy.c:53:5: error: implicit declaration of function 'PrintSockAddr' is invalid in C99 [-Werror,-Wimplicit-function-declaration] PrintSockAddr (pdpy->address, pdpy->addrlen); ^ Signed-off-by: Jeremy Huddleston Sequoia commit 68de911889c66133cc6e2f5c64b18a02e84de500 Author: Jeremy Huddleston Sequoia Date: Sun Oct 18 22:12:14 2015 -0700 Add missing return type (void) for PrintProtoDisplay protodpy.c:49:1: error: type specifier missing, defaults to 'int' [-Werror,-Wimplicit-int] PrintProtoDisplay (struct protoDisplay *pdpy) ^ Signed-off-by: Jeremy Huddleston Sequoia commit 0d8bb02d5ab7af1dc505987c9468c11caf3b889d Author: Jeremy Huddleston Sequoia Date: Sun Oct 18 22:10:41 2015 -0700 xdm: Add missing include of for inet_ntop netaddr.c:226:2: error: implicit declaration of function 'inet_ntop' is invalid in C99 [-Werror,-Wimplicit-function-declaration] inet_ntop(a->sa_family, &((struct sockaddr_in6 *) a)->sin6_addr, ^ Signed-off-by: Jeremy Huddleston Sequoia commit 29ec7d1a3bad0222c58a6be2a3a5d81706ce26e5 Author: Alan Coopersmith Date: Sun Sep 27 18:47:14 2015 -0700 Get rid of an extraneous ; at the end of a C source line Signed-off-by: Alan Coopersmith commit f4ddb33f2168acfee0034379c2f69c82e0aa768a Author: Egbert Eich Date: Fri May 22 10:36:03 2015 +0200 dm: Don't crash if argc == 0 It is not guaranteed that argc > 0. So make sure we don't crash if no valid command line arguments are given. Signed-off-by: Egbert Eich Reviewed-by: Alan Coopersmith commit d0e32620bfb3bc8803bffcec3f0f3b1db6440d51 Author: Matthieu Herrb Date: Sat Mar 14 20:05:25 2015 +0100 Allow the greeter to set the input fields bg color A new 'inpColor' resource is added for that. Signed-off-by: Matthieu Herrb Reviewed-by: Alan Coopersmith commit 6abf2827dd4f0dc1a4972c431131de94fb978199 Author: Alan Coopersmith Date: Thu Feb 26 23:05:24 2015 -0800 Mark LogPanic as noreturn per gcc's suggestion error.c: In function ‘LogPanic’: error.c:93:1: warning: function might be candidate for attribute ‘noreturn’ [-Wsuggest-attribute=noreturn] LogPanic (const char * fmt, ...) ^ Signed-off-by: Alan Coopersmith commit d26ca678071aeaf41d91985ebf8a194231667b24 Author: Alan Coopersmith Date: Thu Feb 26 22:32:21 2015 -0800 Only free input or output to realloc, not both In error cleanup path, check to see if realloc returned NULL, if so, free the still valid input pointer; otherwise the input is no longer valid, so ignore it and free the realloc output pointer. Avoids potential double free if you run out of memory at the exact right spot. Introduced-by: commit d39dbde390f0f609c03dbd79f0bcc6a3486ca8a3 Signed-off-by: Alan Coopersmith commit bd28d86465fc6ba48f6f35ddeb8df9275960b1de Author: Jon TURNEY Date: Mon Feb 23 11:36:41 2015 +0000 Link libXdmGreet with -no-undefined libtool flag "Use -no-undefined to assure libtool that the library has no unresolved symbols at link time, so that libtool will build a shared library on platforms that require that all symbols are resolved when the library is linked." With a recent libtool (since 2.4.5 or so), "can't build shared library unless -no-undefined is specified" is an error, rather than a warning, if ./configure'd --enable-shared. http://tinderbox.x.org/builds/2015-02-22-0009/logs/app-xdm/#build Signed-off-by: Jon TURNEY commit cdc7b575452a621fb467004d607288af6dd4c802 Author: Alan Coopersmith Date: Tue Nov 4 21:44:05 2014 -0800 Only pass -u & -w args to sessreg if --with-{u,w}tmp-file=path specified If not specified, let sessreg use its builtin defaults instead of replicating the logic here (and possibly getting it wrong), especially since in sessreg-1.0.8 and earlier, using the -u & -w flags forces the use of the utmp/wtmp code and not the newer utmpx/wtmpx code. If --without-{u,w}tmp-file or --with-{u,w}tmp-file=none is specified, pass "none" as arguments to sessreg to disable writing to that file. v2: better handling of --with & --without arguments when not passing path, add documentation of the 3 choices to README Signed-off-by: Alan Coopersmith commit a69c64584f614eeaeac92a068715ced5777b0ec9 Author: Alan Coopersmith Date: Fri Aug 1 22:58:54 2014 -0700 Protect against unlikely NULL pointer dereference in FormatChooserArgument NetaddrPort should only return NULL if it wasn't compiled with support for the address family in use, but checking to be sure makes static analyzer complain less. Error: Null pointer dereference (CWE 476) Read from null pointer port at line 219 of xdm/choose.c in function 'FormatChooserArgument'. Function NetaddrPort may return constant 'NULL' at line 77, called at line 216. Null pointer introduced at line 77 of xdm/netaddr.c in function 'NetaddrPort'. at line 220 of xdm/choose.c in function 'FormatChooserArgument'. Function NetaddrPort may return constant 'NULL' at line 77, called at line 216. Null pointer introduced at line 77 of xdm/netaddr.c in function 'NetaddrPort'. [ This bug was found by the Parfait 1.4.0 bug checking tool. http://labs.oracle.com/pls/apex/f?p=labs:49:::::P49_PROJECT_ID:13 ] Signed-off-by: Alan Coopersmith commit 95e6f0ed0730c296b6c52b024c67d86507de1348 Author: Alan Coopersmith Date: Sat May 31 21:39:32 2014 -0700 autogen.sh: Honor NOCONFIGURE=1 See http://people.gnome.org/~walters/docs/build-api.txt Signed-off-by: Alan Coopersmith commit c1375955b733ee8281520e283c7cfb3d93f6d2cf Author: Alan Coopersmith Date: Sat May 31 21:38:41 2014 -0700 configure: Drop AM_MAINTAINER_MODE Signed-off-by: Alan Coopersmith commit f5737904cb77fa546523615bf1582979b2744607 Author: Alan Coopersmith Date: Fri Oct 18 22:54:29 2013 -0700 Ensure fgets read at least one byte before modifying string If a file has a \0 byte (binary file, strange encoding, corruption), fgets() can return a string starting with a \0 byte - check for that before checking to see if the byte before the \0 is a \n, so we don't reach back before the start of our memory buffer. Signed-off-by: Alan Coopersmith Acked-by: walter harms commit a2773de6ea289d85d6b021221f911fc983b08ee5 Author: Alan Coopersmith Date: Sun Sep 1 11:34:40 2013 -0700 Show compile time options in Debug output When debugging, helps figure out which options the distro or builder chose to enable or disable. Signed-off-by: Alan Coopersmith Acked-by: Peter Hutterer commit 3bedc0fef371ade80db85d17ae4deb1d692b027a Author: Matthieu Herrb Date: Sun Aug 18 11:07:54 2013 +0200 Fix format string for systems where time_t is 64 bits long. Signed-off-by: Matthieu Herrb Reviewed-by: Alan Coopersmith commit a0ab1f13b749e9486f5d50e16e67a9de6733b8a4 Author: Thomas Klausner Date: Sun Jun 2 22:20:41 2013 +0200 Add wrapper function for write. gcc-4.5.4 on NetBSD complains: xdm/prngc.c: In function ‘get_prngd_bytes’: xdm/prngc.c:133:2: error: passing argument 1 of ‘atomicio’ from incompatible pointer type xdm/prngc.c:46:16: note: expected ‘ssize_t (*)(int, void *, size_t)’ but argument is of type ‘ssize_t (*)(int, const void *, size_t)’ The problem is that the read(2) and write(2) syscalls differ in the const-ness of their second argument. The wrapper function gets rid of the difference. Signed-off-by: Thomas Klausner Signed-off-by: Alan Coopersmith commit a13b3c0681834fde049bf6b225e9547327458026 Author: Thomas Klausner Date: Fri Jun 28 19:35:39 2013 +0200 Use appropriate format string. Fixes clang warning: format specifies type 'int' but the argument has type 'unsigned long' Signed-off-by: Thomas Klausner Signed-off-by: Alan Coopersmith commit 04e9edeb73dcd7de12e140ca38403c9772d8bebc Author: Eric S. Raymond Date: Wed Jun 19 06:58:27 2013 -0400 Don't rely on the ability to set tab stops. Instead, use TBL and CW fonts in examples. commit 8d1eb5c74413e4c9a21f689fc106949b121c0117 Author: mancha Date: Wed May 22 07:20:26 2013 -0700 Handle NULL returns from glibc 2.17+ crypt(). Starting with glibc 2.17 (eglibc 2.17), crypt() fails with EINVAL (w/ NULL return) if the salt violates specifications. Additionally, on FIPS-140 enabled Linux systems, DES/MD5-encrypted passwords passed to crypt() fail with EPERM (w/ NULL return). If using glibc's crypt(), check return value to avoid a possible NULL pointer dereference. Reviewed-by: Matthieu Herrb Signed-off-by: Alan Coopersmith Notes: Fixes CVE-2013-2179 commit 642d73c50ae19a55975919c84191da15b31608a4 Author: Alan Coopersmith Date: Sun Apr 21 15:37:00 2013 -0700 Avoid fd leak when fdopen() fails in openFiles() Found by parfait 1.1 bug checker: File Descriptor Leak: Leaked File Descriptor newfd at line 590 of xdm/auth.c in function 'openFiles'. newfd initialized at line 573 with open newfd leaks when newfd >= 0 at line 574. Signed-off-by: Alan Coopersmith commit 4ecaac617be1ef59be532671d07f062e52111f3a Author: Alan Coopersmith Date: Fri Apr 19 16:33:12 2013 -0700 Remove old man page note about XDM-AUTHENTICATION-1 It is enabled by default now, when building with current versions of libXdmcp. Signed-off-by: Alan Coopersmith Reviewed-by: Matthieu Herrb commit b1af740f2824b00fd2e073f847e0873b406bc1ad Author: Alan Coopersmith Date: Mon Apr 1 23:37:45 2013 -0700 Stop leaking address struct on every call to getLocalAddress() getLocalAddress() checks the haveLocalAddress static variable to see if it's already set up an address struct, and if not allocates memory to do so and stores a pointer in the localAddress static variable. Unfortunately, it never then set haveLocalAddress, so every time it was called it simply overwrote the previous allocation with a new one. Now we check to see if the allocation succeeded, and if so, then set haveLocalAddress so we don't repeat and waste time & memory on later calls. Reported-by: Ilja Van Sprundel Signed-off-by: Alan Coopersmith commit 87f9c9d8cae9461f22f9b55056433336bea354c8 Author: Alan Coopersmith Date: Sat Feb 23 10:29:02 2013 -0800 Assume signal handlers return void, as C89 requires Drops use of autoconf's obsolete AC_TYPE_SIGNAL & RETSIGTYPE Signed-off-by: Alan Coopersmith commit fa8adede758e2b1e8ae38c84d032b354f0250f49 Author: Jeremy Huddleston Sequoia Date: Thu Jan 24 10:11:28 2013 -0800 Look for pam in both pam/ and security/ paths Signed-off-by: Jeremy Huddleston Sequoia commit 2cef6bcd280f44e115ff238d4f2a1ccb10aaf09f Author: Alan Coopersmith Date: Wed Dec 26 20:43:08 2012 -0800 Remove old Interactive Unix ("ISC") code from xdm Interactive Systems Corp (ISC) made a SVR3 port for i386 systems. It was purchased by Sun in 1992 to beef up Solaris x86 support. Sun ended sales of ISC Unix in 2001, and ended support in 2006. Mostly performed via "unifdef -UISC" followed by imdent, and then manual cleanup. Signed-off-by: Alan Coopersmith commit b6a3c34ee853c5143c7c21a1ed47cfe1cab4e871 Author: Alan Coopersmith Date: Wed Dec 26 20:43:08 2012 -0800 Remove unused NCR/Wollongong TCP ("WINTCP") code from xdm Has never been converted to build in modular builds, so has been unusable since X11R7.0 release in 2005. Was only used with an ancient SVR3 variant from NCR, with the TCP stack addon from Wollongong (now a long forgotten part of Attachmate). Mostly performed via "unifdef -UWINTCP" followed by imdent, and then manual cleanup. Signed-off-by: Alan Coopersmith commit 2e38a23baa19b2bcb3747135e86b289c1e076293 Author: Alan Coopersmith Date: Wed Dec 26 20:43:08 2012 -0800 Remove unused DECnet ("DNETCONN") code from xdm Has never been converted to build in modular builds, so has been unusable since X11R7.0 release in 2005. DNETCONN support was removed from xtrans back in 2008. Mostly performed via "unifdef -UDNETCONN" followed by imdent, and then manual cleanup. Signed-off-by: Alan Coopersmith commit d44bdc127d4838eb67402843ceb122df59ef328e Author: Alan Coopersmith Date: Wed Dec 26 20:43:08 2012 -0800 Remove unused TLI ("STREAMSCONN") code from xdm Has never been converted to build in modular builds, so has been unusable since X11R7.0 release in 2005. All known platforms with TLI/XTI support that X11R7 & later releases run on also have (and mostly prefer) BSD socket support for their networking API. Mostly performed via "unifdef -USTREAMSCONN", followed by imdent, and then manual cleanup. Signed-off-by: Alan Coopersmith commit 78403f6a7420798bf24798811c8c6b936c9ccb34 Author: Alan Coopersmith Date: Fri Jan 6 19:34:30 2012 -0800 Add some missing malloc failure checks Flagged by Solaris Studio 12.3 code analyzer Signed-off-by: Alan Coopersmith commit ad7a54288f62c0266540279dac775ebee68f092e Author: Matthieu Herrb Date: Thu Dec 15 22:14:23 2011 +0100 replace by . Spotted my Marco Peereboom with clang. Reviewed-by: Mark Kettenis Signed-off-by: Matthieu Herrb commit a02edebf21aae37f8564d7b9fad01d5d2942ad8d Author: Matthieu Herrb Date: Mon Nov 7 17:01:44 2011 +0100 Fix build outside of source dir. Fixes distcheck too. Signed-off-by: Matthieu Herrb Reviewed-by: Alan Coopersmith commit 284532c0884893728b75ca37f5d2a9a33f7bc8db Author: Julien Cristau Date: Sat Oct 22 17:14:46 2011 +0200 greeter: link against -lXrender if xft is enabled XmuCvtStringToXftColor uses XRenderParseColor, so require xrender for the xft option, and link against it. Signed-off-by: Julien Cristau Reviewed-by: Alan Coopersmith commit 8eee942be0db913511b4c53f94829e1201dfdf00 Author: Michał Górny Date: Wed Sep 28 21:25:17 2011 +0200 Support systemd startup notification. If libsystemd-daemon support is enabled, xdm uses it to announce its startup as soon as the session is established. This gives the user opportunity to delay I/O-intensive operations until the X server is started so that they would not interfere with its loading while keeping the machine busy when user types in his/her login. Reviewed-by: Jamey Sharp Reviewed-by: Gaetan Nadon Signed-off-by: Alan Coopersmith commit c43eb799774743bc50233eff6643c51a5fbe6899 Author: Alan Coopersmith Date: Tue Sep 20 19:22:48 2011 -0700 Fix warnings about printing longs with int type format strings Signed-off-by: Alan Coopersmith commit 618039261b0c7f14eb3b32c8f636464369724407 Author: Alan Coopersmith Date: Tue Sep 20 19:11:20 2011 -0700 Mark some chars as const to fix gcc -Wwrite-strings warnings Can't fix all the warnings, due to the Xt API, but can fix a bunch. Signed-off-by: Alan Coopersmith commit 011a2710a69cd345a8ee3a6b2f15407b4c3b355a Author: Jeremy Huddleston Date: Sun Sep 25 00:56:15 2011 -0700 Require xt >= 1.0 for appdefaultdir https://bugs.freedesktop.org/show_bug.cgi?id=7237 Signed-off-by: Jeremy Huddleston commit 23949f9a4c30b5dfa67a88b3dd2523f09f163d91 Author: Jeremy Huddleston Date: Sun Sep 25 00:41:25 2011 -0700 configure.ac: Bump to 1.1.11 Signed-off-by: Jeremy Huddleston commit 225493d3c6be64dafec69095f254a1bee6386e33 Author: Alan Coopersmith Date: Tue Sep 20 17:39:34 2011 -0700 fix whitespace issues Performed with: find * -type f | xargs perl -i -p -e 's{[ \t]+$}{}' find * -type f | xargs perl -i -p -e 's{^[ ]+\t}{\t}' git diff -w & git diff -b show no diffs from this change Signed-off-by: Alan Coopersmith commit 8016dfd9080393c23d19b1c34e81d1f544655d5a Author: Matěj Cepl Date: Mon Aug 8 21:26:47 2011 +0200 Use explicitly /bin/sh for running of Xwilling script via su. su nobody -c uses a default shell of the user, which in case of nobody is (at least on Linux distros) /sbin/nologin. Signed-off-by: Matěj Cepl Reviewed-by: Alan Coopersmith Reviewd-by: Mark Kettenis Signed-off-by: Alan Coopersmith commit 0782f1c24c658c06736907dd143f8e67359ac235 Author: Michał Górny Date: Wed Aug 31 18:02:53 2011 +0200 Support installing systemd unit file. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=38339 Signed-off-by: Michał Górny Reviewed-by: Gaetan Nadon Tested-by: Gaetan Nadon Signed-off-by: Gaetan Nadon commit 5574b79c2d6c89f96484b890872ba1594fb6ddd2 Author: Alan Coopersmith Date: Thu Jun 2 21:52:20 2011 -0700 Simplify FailedLogin code Relies on username going out of scope to discard the pointer returned by pam_get_item that pam_end frees at the bottom of the loop. Signed-off-by: Alan Coopersmith Reviewed-by: Jeremy Huddleston commit 29e9393697d0b7158c2c1e0856180713c7c8f925 Author: Alan Coopersmith Date: Thu Jun 2 21:39:16 2011 -0700 Stop using username retrieved from PAM before pam_end frees it. The first time a failed login message was syslogged it had the right username, but subsequent ones kept reusing that pointer, even though PAM had freed it and it may have been reused and filled with something else, resulting in garbage user names for the later login failures. Signed-off-by: Alan Coopersmith Reviewed-by: Jeremy Huddleston commit eca379146cf487cbd05e1698ea12c1835327d1d4 Author: Alan Coopersmith Date: Thu Jun 2 20:46:57 2011 -0700 Add _X_ATTRIBUTE_PRINTF to LogVWrite declaration Suggested by gcc -Wmissing-format-attribute Signed-off-by: Alan Coopersmith Reviewed-by: Jeremy Huddleston commit 7b8a4bb753d9da4cde60379050493d811c9b3044 Author: Alan Coopersmith Date: Thu Jun 2 20:45:32 2011 -0700 Replace GCC_PRINTFLIKE with xproto's _X_ATTRIBUTE_PRINTF The existing GCC_PRINTFLIKE declaration seems to have been broken, since it only defined GCC_PRINTFLIKE if GCC_PRINTFLIKE was already defined. Signed-off-by: Alan Coopersmith Reviewed-by: Jeremy Huddleston commit 7843f1e00caba67025ac75c4985ddd3af7924a9c Author: Alan Coopersmith Date: Thu Jun 2 20:38:29 2011 -0700 Use C99 named initializers for XSetWindowAttributes structure Signed-off-by: Alan Coopersmith Reviewed-by: Jeremy Huddleston commit 3c3f9cde9dda4c74178cc5428ebf8967c26a516a Author: Alan Coopersmith Date: Thu Jun 2 18:33:56 2011 -0700 Bug 13455: allowNullPasswd: true doesn't work until the second login attempt Assign allow_null_passwd and allow_root_login variables' values before call to pam_authenticate() https://bugs.freedesktop.org/show_bug.cgi?id=13455 Based on a fix suggested by: Tim Shumakov Signed-off-by: Alan Coopersmith Reviewed-by: Jeremy Huddleston commit 7d69ff7b9dfcd3e4410f181225f66f51089eef67 Author: Alan Coopersmith Date: Fri May 27 22:46:09 2011 -0700 On Solaris, make sure PAM_TTY is only ever set to an actual /dev path Solaris PAM & auditing insist this is a device file that can be found in the filesystem, so we can't use the display name (":0") like we've been doing (and continue to do on other OS'es). Fixes Solaris bug 6960231: xdm login fails with: pam_unix_cred: cannot load ttyname with c2audit loaded Signed-off-by: Alan Coopersmith commit 68517be0c7ae67989bc3cd845c8aa79ef7040618 Author: Alan Coopersmith Date: Tue May 17 19:37:15 2011 -0700 xdm.man: address only needs 2 S's, not 3 Signed-off-by: Alan Coopersmith commit bd0acffc9e69c4ca39d0881984ae587ad4385934 Author: Alan Coopersmith Date: Sat May 14 10:08:25 2011 -0700 freeifaddrs() when done with it in DefineSelf() Signed-off-by: Alan Coopersmith commit 96362c12ccd08fcb50f697106622d0c0f8a6007a Author: Alan Coopersmith Date: Sat May 14 09:39:21 2011 -0700 Add Solaris 11 libsocket to list of libraries to search for getifaddrs() Signed-off-by: Alan Coopersmith Acked-by: Gaetan Nadon commit 1953570d9cd7c4e57fc270e6146aa13e794be0de Author: Alan Coopersmith Date: Sat May 14 10:52:18 2011 -0700 Only greeter needs XPM CFLAGS & LIBS, not xdm daemon Signed-off-by: Alan Coopersmith Reviewed-by: Mikhail Gusarov Reviewed-by: Julien Cristau Reviewed-by: Jeremy Huddleston Acked-by: Gaetan Nadon commit 47c1b146c786f057026ea2ad89b8cb4c51ee3d50 Author: Alan Coopersmith Date: Sat May 14 10:44:06 2011 -0700 Stop casting return values of malloc and friends It's not needed on modern mallocs that return void *, and can hide missing prototype errors that cause the compiler to assume int is returned (a bad thing to assume in 64-bit builds). Signed-off-by: Alan Coopersmith Reviewed-by: Mikhail Gusarov Reviewed-by: Julien Cristau Reviewed-by: Jeremy Huddleston Reviewed-by: Mark Kettenis commit f29b73ba549fbdcbe1361c016fc40cc424c32e9b Author: Alan Coopersmith Date: Sat May 14 10:33:50 2011 -0700 Stop casting free() arguments to (char *) Signed-off-by: Alan Coopersmith Reviewed-by: Mikhail Gusarov Reviewed-by: Julien Cristau Reviewed-by: Jeremy Huddleston Reviewed-by: Mark Kettenis commit 6cb6fcd3a95bc125615d4a6736712bcc45ad7685 Author: Alan Coopersmith Date: Sat May 14 10:24:06 2011 -0700 Stop checking for NULL before calling free() Signed-off-by: Alan Coopersmith Reviewed-by: Mikhail Gusarov Reviewed-by: Julien Cristau Reviewed-by: Jeremy Huddleston Reviewed-by: Mark Kettenis commit d39dbde390f0f609c03dbd79f0bcc6a3486ca8a3 Author: Alan Coopersmith Date: Sat May 14 09:29:30 2011 -0700 Fix potential memory leak in allocation failure cleanup path Error: Memory leak (CWE 401) Memory leak of pointer 'newargv' allocated with realloc(((i8*)argv), ((i * 4) + 8)) at line 239 of /export/alanc/X.Org/git/app/xdm/xdm/util.c in function 'parseArgs'. 'newargv' allocated at line 231 with realloc(((i8*)argv), ((i * 4) + 8)). newargv leaks when newargv != 0 at line 234 and save == 0 at line 234. [This bug was found by the Parfait 0.3.7 bug checking tool. For more information see http://labs.oracle.com/projects/parfait/ ] Signed-off-by: Alan Coopersmith Reviewed-by: Mikhail Gusarov Reviewed-by: Julien Cristau Reviewed-by: Jeremy Huddleston commit 4b9cbfd3f4d16000120c3241503c7a6102ae8afe Author: Gaetan Nadon Date: Fri Mar 4 20:31:01 2011 -0500 man: replace hard coded section number (1) with __appmansuffix__ Signed-off-by: Gaetan Nadon commit f394b7e3c7d0437a4415fe99965b866e35066713 Author: Alan Coopersmith Date: Mon Feb 21 16:52:19 2011 -0800 greeter: Make sure cursor stays in bounds too Signed-off-by: Alan Coopersmith commit 7d5c2364cc6c2b7338b4df9f1be0b621ca9fd2e7 Author: Alan Coopersmith Date: Mon Feb 21 16:43:41 2011 -0800 greeter: Replace several #ifdef XPM blocks with LOGO_W macro Refactor code assuming compiler is smart enough to optimize out any that reduce to + 0 or - 0 if building without XPM defined. Signed-off-by: Alan Coopersmith commit f59d8f32c755b8747acf71aa3ab4c4809bff4ebf Author: Alan Coopersmith Date: Mon Feb 21 15:54:00 2011 -0800 greeter: Make sure text input areas stay inside the lines Regression introduced by f8585c60831a8e5ddebce18bdd7e78d217a822c5 broke bounds checking for text displayed in input fields. Since this makes each TEXT_WIDTH value only be used once, just use them directly instead of storing the result in a variable. Signed-off-by: Alan Coopersmith commit 3297eb892017c850f25d3dc4a37095612a20a381 Author: Alan Coopersmith Date: Mon Feb 21 15:53:23 2011 -0800 greeter: Add echoPasswdChar resource to set character to display Stop hardcoding it to '*'. Allows setting a resource with no value to to advance the cursor without drawing text (as was previously the default). Resolves https://bugs.freedesktop.org/show_bug.cgi?id=32794 Signed-off-by: Alan Coopersmith commit 472dc516e7d0190d81fdedd817261ee41bf8ada6 Author: Alan Coopersmith Date: Sat Feb 19 22:33:33 2011 -0800 greeter: inline valueMask for xpm window to avoid shadowing argument The Realize function names one of its arguments valueMask, and the valueMask variable in the inner scope is just used as a static set of mask flags, so just pass them directly to the function to reduce confusion and clear the gcc -Wshadow warning: Login.c: In function `Realize': Login.c:1901: warning: declaration of 'valueMask' shadows a parameter Login.c:1871: warning: shadowed declaration is here Signed-off-by: Alan Coopersmith commit b0dd4a3da0001a4510bdca6726a8ce6bfe632c28 Author: Alan Coopersmith Date: Sat Feb 19 22:30:06 2011 -0800 greeter: Remove unused extern dpy that is shadowed by local variables Resolves these warnings from gcc -Wshadow: greet.c: In function `InitGreet': greet.c:244: warning: declaration of 'dpy' shadows a global declaration greet.c:146: warning: shadowed declaration is here greet.c: In function `CloseGreet': greet.c:326: warning: declaration of 'dpy' shadows a global declaration greet.c:146: warning: shadowed declaration is here greet.c: At top level: greet.c:431: warning: declaration of 'dpy' shadows a global declaration greet.c:146: warning: shadowed declaration is here Signed-off-by: Alan Coopersmith Reviewed-by: Mark Kettenis commit 5bad823955542b99292783391b3f63a049fa2efc Author: Alan Coopersmith Date: Sat Feb 19 14:12:56 2011 -0800 Delete some unused variables auth.c: In function `DefineSelf': auth.c:1045: warning: unused variable `n' error.c: In function `Debug': error.c:116: warning: unused variable `buf' Signed-off-by: Alan Coopersmith Reviewed-by: Mark Kettenis commit 3e3a45176d232c4e3f23ed6bc0b46bf660ddf271 Author: Servaas Vandenberghe Date: Sat Feb 19 14:06:57 2011 -0800 Add resource reservAttempts to allow a few successive crash-type exits https://bugs.freedesktop.org/show_bug.cgi?id=20546 https://bugs.freedesktop.org/attachment.cgi?id=43050 Signed-off-by: Servaas Vandenberghe Signed-off-by: Alan Coopersmith commit d0870e66dd9d8a41c9b6de65c4a9243c0a3fdc6e Author: Servaas Vandenberghe Date: Sat Feb 19 13:15:58 2011 -0800 crash detect: use StopDisplay(). This patch solves a benign bug: on server crash the display is removed but the server exit code is ignored. Proposed solution: substitute RemoveDisplay() by StopDisplay() thus enabling the wait for child exit synchronism. https://bugs.freedesktop.org/show_bug.cgi?id=20546 https://bugs.freedesktop.org/attachment.cgi?id=43049 Signed-off-by: Servaas Vandenberghe Signed-off-by: Alan Coopersmith commit c4031966dcbc47b2cc85b83ad78efcc64455cf72 Author: Fernando Tarlá Cardoso Lemos Date: Sat Feb 19 17:53:08 2011 -0200 Fix missing linking dependency on -ldl. Recent versions of GCC ship with a linker that doesn't add the deps of the DSOs to the linking process. This behavior is also found in GNU gold. This change fixes building with those linkers. Some references: http://wiki.debian.org/ToolChain/DSOLinking https://fedoraproject.org/wiki/UnderstandingDSOLinkChange Signed-off-by: Alan Coopersmith Reviewed-by: Gaetan Nadon commit 208c7df5572f6ad8a63a4ee0fb1d5fd68c809653 Author: Alan Coopersmith Date: Fri Feb 18 18:05:04 2011 -0800 xdm itself doesn't need to link with Xinerama library Xinerama calls are made in the greeter & chooser, but not core daemon Signed-off-by: Alan Coopersmith commit 250c9931f45c73dda9d07c6bddc734c1445cfa5c Author: Alan Coopersmith Date: Fri Feb 18 18:00:11 2011 -0800 config: rename XDM_PRINT to XDM_TOOLKIT Name is a leftover of checking for non-Xprint Xaw7 vs. Xprint Xaw8, but xdm doesn't print, just needs a toolkit to display with. Signed-off-by: Alan Coopersmith commit edd8d3622528351770fd9b5dc2242b16e6f70904 Author: Gaetan Nadon Date: Wed Jan 12 15:29:50 2011 -0500 config: replace deprecated AC_HELP_STRING with AS_HELP_STRING This silences an Automake warning. Signed-off-by: Gaetan Nadon commit cf45a0ceee92c2fb048ff8882cf0bea200506d11 Author: Gaetan Nadon Date: Tue Nov 16 11:42:50 2010 -0500 config: AM_PROG_CC_C_O is no longer needed All per-target flags have been removed now that each target sits in its own directory. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit e509059f307f81d055a1ab01f4cb3a64b3157dce Author: Gaetan Nadon Date: Wed Aug 25 20:44:37 2010 -0400 config: move appdefault makefile to app-defaults dir. For this package it is best not to break the pattern of each directory having its own makefile. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit 8ee6a2678f9045c31366525bcaae5baf59a20930 Author: Gaetan Nadon Date: Wed Aug 25 20:19:43 2010 -0400 config: mv xdm in its own directory Prevents the use of per target flags. Clearly shows which libraries and compiler options apply. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit dd8a5b9f50deb9d91bb33cdd12fe083d39cd7d23 Author: Gaetan Nadon Date: Tue Aug 24 11:32:53 2010 -0400 config: move common headers into the include directory They provide interfaces to multiple executables Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit eb0e5a3a665cd4dbd376f1a1cbd6d0c7ace22572 Author: Gaetan Nadon Date: Mon Aug 23 20:04:15 2010 -0400 config: move xdmshell into its own directory Prevents the use of per target flags. Clearly shows which libraries and compiler options apply. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit 2d520f71a0c89faf5522f5e37c09bdd5f933a574 Author: Gaetan Nadon Date: Mon Aug 23 14:42:23 2010 -0400 config: move chooser into its own directory Prevents the use of per target flags. Clearly shows which libraries and compiler options apply. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit f3b0019752e5b683c6e273eba15a4ecc9f55c5ae Author: Gaetan Nadon Date: Sat Nov 13 16:17:44 2010 -0500 config: move man pages into their own directory Replace lowercase $(xdmlibdir) with $(XDMLIBDIR) Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit 1dc0ef42cf009596db60a9fd08435621f70b81e7 Author: Gaetan Nadon Date: Fri Nov 12 17:07:38 2010 -0500 config: use AM_V_GEN instead of customized macros for AM_SILENT_RULES Reviewed-by: Alan Coopersmith Reviewed-by: Mikhail Gusarov Signed-off-by: Gaetan Nadon commit 083f3d0ee8ecbb48b86dddfcf2f172fafb579f08 Author: Gaetan Nadon Date: Tue Nov 23 15:15:33 2010 -0500 config: relocate key_setnet in section "Check for header files" No configuration changes Reviewed-by: Mikhail Gusarov Signed-off-by: Gaetan Nadon commit e4535a52148d58c3fe91baebdcfe0187a07519b9 Author: Gaetan Nadon Date: Fri Nov 12 16:25:53 2010 -0500 config: relocate AC_FUNC_FORK in section "Check for system library functions" No configuration changes. Reviewed-by: Mikhail Gusarov Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit 63e882f86809419f8efdf2717050c96a15345c7b Author: Gaetan Nadon Date: Fri Nov 12 16:21:54 2010 -0500 config: comment libxtrans macros as they are order sensitive XTRANS_SECURE_RPC_FLAGS must be called after XTRANS_CONNECTION_FLAGS which finds libraries like -lsocket, -lnsl or -lws32_32. The found libraries are pre-pended to $LIBS which is not obvious. Reviewed-by: Mikhail Gusarov Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit 73763eb718cba54963e0cf71b5316fdce2762c1f Author: Gaetan Nadon Date: Mon Oct 25 14:19:20 2010 -0400 config: rework check for random number generator Following a similar pattern to PAM and SELinux checks. Unchanged: if a user has requested the use of a random device and none can be found, the configuration aborts. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit 10117ab7bc89ca65d313e0c6675e27d336a96925 Author: Gaetan Nadon Date: Mon Sep 6 15:08:36 2010 -0400 config: integrate check for arc4random in appropriate sections The AC_SEARCH_LIBS is done in "Check for libraries" section. Move AC_SUBST and AM_CONDITIONAL over there as well. Move AC_CHECK_FUNCS for arc4random to "library functions" section No function change. Reviewed-by: Mikhail Gusarov Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit 5d7d55646d4867e7b3f736d318575554c2414361 Author: Gaetan Nadon Date: Fri Oct 22 20:39:27 2010 -0400 config: upgrade the checking for SELinux support Use "auto" rather than "try" for consistency with other modules. Update help string to mention default value. Unchanged: if configured --with-selinux and -lselinux is misisng, abort the configuration. Change HAVE_SELINUX to USE_SELINUX to be consistent with USE_PAM, USE_XFT, USE_XPM and USE_XINERAMA. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit 5718767b882dc46f9393fd6b42f443227061a807 Author: Gaetan Nadon Date: Mon Nov 22 16:08:18 2010 -0500 config: upgrade the checking for PAM support Use "auto" rather than "try" for consistency with other modules. Update help string to mention default value. Unchanged: if configured --with-pam and -lpam is misisng, abort the configuration. Continue with USE_PAM rather than HAVE_PAM_OPEN_SESSION as we are checking for a feature rather a function alone. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit 529a045fa6a25334be469f633531fe1324dcf14a Author: Gaetan Nadon Date: Fri Oct 22 13:51:43 2010 -0400 config: isolating -lselinux to a single target is not required Due to previous patches, -lselinux, if installed on the configured system, is included in $LIBS already. Reviewed-by: Mikhail Gusarov Signed-off-by: Gaetan Nadon commit 0b1a949b7c1ce09136d3e4098b68a733d7bb32e2 Author: Gaetan Nadon Date: Thu Sep 2 19:45:54 2010 -0400 config: use AC_CHECK_FUNCS for mkstemp, getifaddrs and getspnam Using AC_CHECK_FUNCS defines HAVE_xxx macro in config.h following a consistent naming convention. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit b6309b26edd477f45dd34b6d746eb2ac1e3fe9fc Author: Gaetan Nadon Date: Thu Sep 2 17:47:55 2010 -0400 config: use AC_CHECK_FUNCS for setusercontext AC_CHECK_FUNCS defines HAVE_SETUSERCONTEXT The replaced code made an incorrect assumption that it was only availble on BSD-like systems. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit 80b44cfae4ab244ab4fd9d0ed0e089d946526755 Author: Gaetan Nadon Date: Wed Sep 1 09:37:42 2010 -0400 config: use AC_CHECK_FUNCS for setprocttile AC_CHECK_FUNCS defines HAVE_SETPROCTITLE The replaced code made an incorrect assumption that it was only availble on BSD-like systems. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit d9ab9445d1c52174788fc5df34e5379747623410 Author: Gaetan Nadon Date: Tue Sep 7 16:47:26 2010 -0400 config: add "Check for system library functions" Relocate the existing AC_CHECK_FUNCS statement. The functions are checked after the libraries checks to benefit from the $LIBS updated values. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit 28d6283c5bfa9a7d19635b95de26907987799e2b Author: Gaetan Nadon Date: Wed Oct 20 15:35:51 2010 -0400 config: relocate headers, typedefs, and compiler characteristics Those checks are next following the "Check for system libraries" section. They are done before xorg specific configuration. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit 849a74c4146d1f1cb961026be2540b4a9970fa26 Author: Gaetan Nadon Date: Tue Sep 7 16:08:06 2010 -0400 config: add "Check for system libraries" section This section gathers all the system libraries needed for xdm features. They may be in standard C library on some platforms and in discrete libraries on others. Any xorg library is excluded from this section. XTRANS macros will be invoked at a later time and contribute additional libraries. Although a function is used to search for the library, this should not be confused with function checking (AC_CHECK_FUNC). Sample configuration output on GNU/Linux: checking for library containing getifaddrs... none required checking for library containing getspnam... none required checking for library containing setproctitle... no checking for library containing setusercontext... no checking for library containing arc4random... -lbsd checking for library containing crypt... -lcrypt In the Makefile, libs are pre-pended: LIBS = -lcrypt -lbsd Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit 4455d61291b7662e652953ca326627104e0d5494 Author: Gaetan Nadon Date: Tue Sep 7 15:45:44 2010 -0400 config: relocate the "Check for programs section" Following the usual layout, programs are check before the xorg specifics start. Signed-off-by: Gaetan Nadon commit 2ff31d55be7fb62aece1324ea14fed9cdac23789 Author: Gaetan Nadon Date: Tue Sep 7 15:38:15 2010 -0400 config: libtool: disable production of static libraries. Regroup libtool statements under the "Initialize" libtool section The greeter is only used as a shared library that is dynamically loaded. Alan Coopersmith wrote: "I don't think it's intended to be used as a shared library, but instead to allow sites to drop in their own greeter module for greater customization than allowed via just .Xresources." Signed-off-by: Gaetan Nadon commit b4d166d8c4f8ebc28fcd4d6f24065951989d11b2 Author: Gaetan Nadon Date: Tue Sep 7 14:36:03 2010 -0400 config: replace deprecated AM_CONFIG_HEADER with AC_CONFIG_HEADERS Regroup AC statements under the Autoconf initialization section. Regroup AM sttaements under the Automake initialization section. Add missing AC_CONFIG_SRCDIR Signed-off-by: Gaetan Nadon commit 75a285c2c7cd8c3567126dafbdc047d2bdac421c Author: Gaetan Nadon Date: Tue Aug 31 17:25:02 2010 -0400 config: look for PAM support on darwin as well There is an assumption that PAM support is not available on darwin. A quick browse on the net indicates otherwise. For systems with PAM, if any, this authentication method will be used, as per original configuration intent. Signed-off-by: Gaetan Nadon commit 22e7cc3458107662de736f9c82679d32197625bc Author: Gaetan Nadon Date: Tue Aug 31 10:52:58 2010 -0400 config: remove unused OS_CFLAGS variable Now unused as a result of previous patches Reviewed-by: Mark Kettenis Signed-off-by: Gaetan Nadon commit c76330b71a7d65620e411df7b327ad82bff97d90 Author: Gaetan Nadon Date: Mon Aug 30 19:51:24 2010 -0400 config: use AC_CHECK_HEADERS for sys/param.h This is the FreeBSD porting guide recommended method to check for BSD 4.3 Net2 or newer systems. Reviewed-by: Mark Kettenis Signed-off-by: Gaetan Nadon commit 96380df139761274e03babf71b7cb6692acb847a Author: Gaetan Nadon Date: Mon Aug 30 15:51:16 2010 -0400 config: definition of CSRG_BASED in configure.ac is flawed and redundant CSRG_BASED is defined in both the xserver using platform checks and in Xosdefs.h using compiler macros. The one from X11/Xosdefs.h will be used through already included headers: # if defined(__OpenBSD__) || defined(__NetBSD__) || defined(__FreeBSD__) \ || defined(__APPLE__) || defined(__DragonFly__) # ifndef CSRG_BASED # define CSRG_BASED # endif # endif Reviewed-by: Mark Kettenis Signed-off-by: Gaetan Nadon commit 1d4f032110924d90cb2302d5dcc241e961043a37 Author: Gaetan Nadon Date: Mon Aug 30 09:32:06 2010 -0400 config: remove unused define NO_LASTLOG for Darwin This is a leftover from commit 6ae3766444c62ee when sessreg was broken out so other display managers like gdm could use it without having to install all of xdm. Signed-off-by: Gaetan Nadon commit 8b7999f8e0f797a593ac2f4697ba3be983b421ae Author: Gaetan Nadon Date: Mon Aug 30 07:39:56 2010 -0400 config: use libtool -export-dynamic option for reverse dependencies This replaces -rdynamic which is a GNU/Linux only solution. "If symbols from your executable are needed to satisfy unresolved references in a library you want to dlopen you will have to use the flag -export-dynamic. You should use -export-dynamic while linking the executable that calls dlopen." It is used by the xserver, in Xdmx for example. Signed-off-by: Gaetan Nadon commit 50c96170ad42321310c346cf412f9ae7e80ec2a7 Author: Gaetan Nadon Date: Sun Aug 29 19:56:59 2010 -0400 config: AC_LIBTOOL_DLOPEN is required for dynamic linking It adds the following tests in the configuration : checking for shl_load... no checking for shl_load in -ldld... no checking for dlopen... no checking for dlopen in -ldl... yes checking whether a program can dlopen itself... yes checking whether a statically linked program can dlopen itself... no This has not resulted in any compiler/linker flags change on a GNU/Linux platform. Signed-off-by: Gaetan Nadon commit 5d79c0fad950ee6b83011a6c0242c9dc00c711a7 Author: Gaetan Nadon Date: Sun Aug 29 09:05:52 2010 -0400 config: remove AC_LIBTOOL_WIN32_DLL As of 2002, this is no longer required and is a no-op in libtool v 1.5 and higher. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit 0a90d3a5f580337e5d21eac4316b282e81bae68f Author: Gaetan Nadon Date: Sun Aug 29 09:02:19 2010 -0400 remove AC_C_INLINE as all compilers support inline keyword. This macro is not used anywhere else in xorg. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit 4afafa90e79882b464b4aaee73826fb95136e7b5 Author: Gaetan Nadon Date: Sun Aug 29 09:00:45 2010 -0400 config: remove AC_PROG_CC as it overrides AC_PROG_C_C99 XORG_STRICT_OPTION from XORG_DEFAULT_OPTIONS calls AC_PROG_C_C99. This sets gcc with -std=gnu99. If AC_PROG_CC macro is called afterwards, it resets CC to gcc. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit f56891b74f40df456e2e447745f70665d87d8596 Author: Gaetan Nadon Date: Sun Aug 29 08:58:48 2010 -0400 config: remove AC_PROG_INSTALL provided by XORG_DEFAULTS Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit a0e103250ffa2d652fa4b2a6e8c719d54f616988 Author: Gaetan Nadon Date: Sun Aug 29 08:27:28 2010 -0400 greeter: transfer -DGREET_LIB from configure.ac to Makefile.am It does not depend on module configuration. It should not mixed with flags required by dependencies. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit 7e223d3ac6c0d549a7d6e4dcc86a053e19594028 Author: Gaetan Nadon Date: Sat Aug 28 20:11:28 2010 -0400 greeter: only build the shared library version There is no evidence that the static version is needed since monolith as hinted by the comment in configure.ac. The greeter code is now all managed by the greeter Makefile. The configure option enable-dynamic-greeter no longer needed. GREET_USER_STATIC is no longer needed. GREET_LIB is still needed in greet.h as it is compiled with both session.c for xdm execuatable and greeter shared lib. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit 674f08cbcbf9c4a29560e8b32e0335d9638b6868 Author: Gaetan Nadon Date: Sat Aug 28 19:43:03 2010 -0400 config: remove copying Chooser.ad to Chooser This was removed from all other apps with resources in app-defaults. The Chooser resource file is a file in git that gets installed and distributed. Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit b8ca599af4a22c5cd1b2aaff203607fe8e5b99d4 Author: Gaetan Nadon Date: Mon Aug 23 07:02:44 2010 -0400 man: build man page using sed rather than the C preprocessor This fixes misalignments to correctly display \n and \ for sample file. No source code changes needed to fix that. Replace XCOMM IMakefile comment with #. Replace #if with: .if !'x.VARNAME'x.' .ig [man page text] .. If $(VARNAME) is empty, the man page text is shown If $(VARNAME) is not empty, the man page text is skipped Or replace #if with: .if 'VARNAME'' .ig [man page text] .. If $(VARNAME) is empty, the man page text is skipped If $(VARNAME) is not empty, the man page text is shown In DisplayManager.randomDevice, the default /dev/urandom is no longer displayed with double-quotes which is consistent with other default values. This was a cpp side-effect. Tested on Debian with groff and Solaris with nroff Co-authored-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit 86f354f0a970e2c39e65b44832aad6ad69f30dc5 Author: Gaetan Nadon Date: Sun Aug 22 17:47:39 2010 -0400 man: conditionally include DisplayManager.randomFile resource This resource follows the same pattern as prndSocket and prngPort. It is displayed to the user only if ARC4_RANDOM is not defined. It seems to be a simple omission in the man page. Refer to resource.c: char *randomFile; char *randomDevice; char *prngdSocket; int prngdPort; Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit edbe0ce24ca9813fdff30c894c8174df188a1ae2 Author: Gaetan Nadon Date: Sun Aug 29 08:49:23 2010 -0400 config: upgrade to util-macros 1.8 for additional man page support Use MAN_SUBST now supplied in XORG_MANPAGE_SECTIONS The value of MAN_SUBST is the same for all X.Org packages. Use AC_PROG_SED now supplied by XORG_DEFAULT_OPTIONS Use the appropriate platform version of sed Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit d24f9406cf3d6560059a86394b4db98d22973556 Author: Gaetan Nadon Date: Thu Aug 26 12:11:27 2010 -0400 Fix whitespace issues as reported by git diff Reviewed-by: Alan Coopersmith Signed-off-by: Gaetan Nadon commit 275f45c5b28e426a594237d36f4c794784d71f28 Author: Gaetan Nadon Date: Mon Aug 23 14:06:42 2010 -0400 config: remove redundant entries added in .gitignore The m4 generated macros are included in the default section Signed-off-by: Gaetan Nadon commit 8f85641ac03f4b55f8618edde94adcc43039bb20 Author: Gaetan Nadon Date: Sat Aug 21 10:20:18 2010 -0400 config: upgrade AC_DEFINE_DIR to AX_DEFINE_DIR Use the latest version now hosted by GNU. The renaming protects Autoconf namespace. There is no functional change in the macro. Signed-off-by: Gaetan Nadon commit 0a4c314d4cfc79e8a48c6eafac01ba2762ff571a Author: Alan Coopersmith Date: Mon Apr 12 11:28:30 2010 -0700 Only install xdmshell if --enable-xdmshell is passed to configure As the xdmshell man page explains, it's used in uncommon configurations and is likely to need site-specific review/customization. Signed-off-by: Alan Coopersmith commit 1da26b3c3128008315f83c3e47e21e66f2d40afe Author: Alan Coopersmith Date: Tue Mar 16 18:29:09 2010 -0700 Add man page for xdmshell Fixes: X.Org bug #7342 - http://bugs.freedesktop.org/show_bug.cgi?id=7342 X Consortium bug #4559 (reported 30 Sep 1991) Text based on the X11R4 release notes description of xdmshell from: http://ftp.x.org/pub/X11R4/RELNOTES.txt Signed-off-by: Alan Coopersmith Reviewed-by: Fernando Carrijo commit 5cf2a248f30e309cda6f0ae26a863bf3f5521fbe Author: Julien Cristau Date: Sat May 1 19:46:53 2010 +0200 configure: fix SELinux check to not use XDM_LIBS XDM_LIBS is set by pkg-config, so we don't want to set it here. Debian bug#556694 Signed-off-by: Julien Cristau commit 5201ce6666f2aac60960e77857664cefa65c318c Author: Alan Coopersmith Date: Mon Apr 12 17:05:46 2010 -0700 s/Sun/Oracle/g Signed-off-by: Alan Coopersmith commit ca19bcccc4e39f5499945edb5a1f177159867bbc Author: Alan Coopersmith Date: Tue Mar 16 16:56:56 2010 -0700 Check for allowRootLogin on PAM and non-OpenBSD passwd authentication backends http://bugs.freedesktop.org/show_bug.cgi?id=25112 Signed-off-by: Alan Coopersmith commit 2eb565827568f619b28fdaf2b75cb5bca0586a45 Author: Julien Cristau Date: Sat Apr 10 15:53:31 2010 +0200 Delete empty comment in Xresources.cpp commit 7006d5c582e382660437a64b749822116823ecee Author: Julien Cristau Date: Sat Apr 10 03:48:05 2010 +0200 Bump to 1.1.10 commit 7c4c0592aca80cc8affe4e94d2742caa754d5be3 Author: Julien Cristau Date: Sun Apr 4 19:20:39 2010 +0200 Add missing brace in previous commit Thanks to cjb and tinderbox. Signed-off-by: Julien Cristau commit 8eb897bb980dd6ce3f8ade517a8a39023a477743 Author: Julien Cristau Date: Tue Mar 23 19:40:49 2010 +0100 xdmcp: disable IPV6_V6ONLY for ipv6 listening sockets This allows ipv4 connections mapped to ipv6, in case the system default is backwards. Signed-off-by: Julien Cristau Reviewed-by: Jeremy Huddleston commit 3a4f890fa9466ed27d49ce97adbcad30b840d3d4 Author: Julien Cristau Date: Tue Mar 23 19:40:48 2010 +0100 Don't remove the pid file from xdm child processes The parent xdm process registers RemovePid with atexit(), which means that any child exit would trigger the (wrong) removal of the pidfile. So in RemovePid, don't do anything if we're not the parent xdm process. Signed-off-by: Julien Cristau Reviewed-by: Jeremy Huddleston commit 931c98390274a9e0c62c41c5e9ceed6681e7a9b7 Author: Gaetan Nadon Date: Sat Mar 13 15:19:37 2010 -0500 lint: option -rdynamic is not valid for the lint program Use xdm_LIBS instead. Tested on Solaris. Signed-off-by: Gaetan Nadon commit 34b9c0e02bc2d36da2c8c5ee468b2a2d63914610 Author: Alan Coopersmith Date: Tue Mar 16 16:33:48 2010 -0700 Reject PAM conversation calls after login dialog is closed Based on patch suggested by Bjoern A. Zeeb to fix http://bugs.freedesktop.org/show_bug.cgi?id=10522 Signed-off-by: Alan Coopersmith commit afc752d1c483e77de9aa3cb9532a67d95fd27dd9 Author: Alan Coopersmith Date: Tue Mar 16 11:23:30 2010 -0700 Make sure username is not NULL when calling syslog from FailedLogin() Signed-off-by: Alan Coopersmith commit 0f18bdfa7fcfe100e487f4c9f91ae37a125ef0f0 Author: Johannes Dewender Date: Fri Nov 13 21:28:23 2009 +0100 Bug #25066: exec sessreg Sessreg saves the pid of the calling process in utmp. If this process is terminated the session is implicitly deleted. Xstartup is called and the process id is gone right when the script is done so the session is closed right away. Using "exec" will save the pid of the master process of this login. Signed-off-by: Johannes Dewender Tested-by: Johannes Dewender Acked-by: Julien Cristau Signed-off-by: Alan Coopersmith commit c9cdd56df50f280e90ba95cfa933222f94ad2677 Author: Alan Coopersmith Date: Mon Mar 15 23:34:04 2010 -0700 Move m4 macros to m4 subdir as automake/libtool recommend Signed-off-by: Alan Coopersmith commit b9226288b96f0c5988d2c2f52718674d39803a5e Author: Alan Coopersmith Date: Mon Mar 15 23:21:30 2010 -0700 Replace hardcoded NAMELEN of 14 for ancient SysV with MAXNAMELEN Signed-off-by: Alan Coopersmith commit af916ebc97a3bd6208f1376e52a4310099b48622 Author: Alan Coopersmith Date: Mon Mar 15 18:12:05 2010 -0700 echo_passwd should key off PAM no-echo state, not prompt position Signed-off-by: Alan Coopersmith commit dd9dc06055e16cd72ff34c2caea22a6627803fa5 Author: Georgy A. Shepelev Date: Wed Dec 9 09:34:02 2009 +0300 xdm: add documentation of the "EchoPasswd" option to the man page Signed-off-by: Georgy A. Shepelev commit 7437298deab265b7669043d4a470a684201f5f3c Author: Georgy A. Shepelev Date: Wed Dec 9 12:18:50 2009 +0300 Adding an option to show stars instead of the password itself. The behaviour can be controlled via 'xlogin*echoPasswd' option in Xresource file. The default option value is 'false'. Signed-off-by: Georgy A. Shepelev Tested-by: Georgy A. Shepelev [Reformatted to match existing code style by Alan Coopersmith] Signed-off-by: Alan Coopersmith commit 34d120f31347697886a419411d9d4d825874f3f0 Author: Alan Coopersmith Date: Fri Jan 15 13:23:24 2010 -0800 Update Sun license notices to current X.Org standard form Signed-off-by: Alan Coopersmith commit 504bb1aee60d570d8676a61acbe32c66d6069c45 Author: Dmitry V. Levin Date: Tue Jan 12 14:38:33 2010 +0000 greeter: fix logging of failed login attempts When PAM rejects a login attempt, the "username" variable remains uninitialized, which results to garbage being syslogged instead of login name. Explicit initialization helps to avoid this issue. Fixes FreeDesktop Bug #26015 Signed-off-by: Dmitry V. Levin Signed-off-by: Alan Coopersmith commit 7d8b4c16d9307f9fa984da7ac5cc00cb945cac09 Author: Alan Coopersmith Date: Tue Jan 12 10:46:38 2010 -0800 Raise xorg-macros requirement to 1.4 Needed since the changes in a4a8f7b83afc9a46bc989c0eeb528a46b3a1db5d depend on the INSTALL file delivered in xorg-macros 1.4 Signed-off-by: Alan Coopersmith commit b69f12706abc728e9c16449f52f02ae0d3a0ee62 Author: Alan Coopersmith Date: Tue Jan 12 10:24:34 2010 -0800 Remove workaround for X11R3 server bug The comment promised 'compatibility until at least R4', so we're 20 years past due for removing this. Signed-off-by: Alan Coopersmith Reviewed-by: Julien Cristau commit c925709069d7515bb94f43e4b88155a95e41c8fe Author: Branden Robinson Date: Mon Nov 18 04:24:48 2002 -0500 rewrite StorePid() Update StorePid() function to use Matthieu Herrb's changes that refuse to open an existing pid file, and take more care with the size of the Pid_t type. Matthieu Herrb rewrote the StorePid() function based on my changes; he made it more careful with the size of Pid_t, and treats an existing pid file as a failure. I then made some more changes: use _SysErrorMsg() instead of strerror(), and don't assume that the process id we write to the pidFile is 5 digits. Forward-ported by David Nusinow, Eugene Konev and Julien Cristau. Signed-off-by: Julien Cristau Reviewed-by: Alan Coopersmith Reviewed-by: Matthieu Herrb commit 6d393844dca10823f85d1ac797879fc6e00eae59 Author: Manoj Srivastava Date: Tue Jan 5 16:40:21 2010 +0000 xdm: add SELinux support Initial patch submitted in Debian bug#233551. Forward-ported to modular X by Eugene Konev (changes: remove Imakefile hunks, add --with-selinux flag to configure.ac). Updated to latest SE Linux code by Russell Coker 3rd Aug 2008, with bugfix from Julien Cristau (Debian bug#493524). Signed-off-by: Julien Cristau Reviewed-by: Alan Coopersmith Reviewed-by: Matthieu Herrb commit 90c2cc57cdf911cec2eec185f357868209212c79 Author: Branden Robinson Date: Tue Jan 5 16:40:21 2010 +0000 Improve logging of xdm's script handling * Make execution of the session program an informational log message (with LogInfo()), not a Debug() message. * Ensure that source()d scripts (Xreset, Xsetup, Xstartup) can be fopen()ed before invoking runAndWait() on them. If they can, LogInfo() the fact. If they cannot, LogInfo() that, too, and use _SysErrorMsg() to report why fopen() failed. * Make source() complain using Debug() when it is given a null pointer in its file argument. * For clarity, make source() return from only one location. Also see Debian bug #219311. Forward ported by Eugene Konev. Signed-off-by: Julien Cristau Reviewed-by: Alan Coopersmith Reviewed-by: Matthieu Herrb commit 5222d28e8d8e5b4cc705f1a637aace405ad32bd5 Author: Branden Robinson Date: Tue Jan 5 16:40:21 2010 +0000 improve error logging Make several LogError() and Debug() messages more informative. Change LogError() invocations to use _SysErrorMsg() where errno might be set (and not clobbered by intermediate calls). Also make LogError() the first thing we do after an error condition in those cases. Forward-ported by Julien Cristau . Signed-off-by: Julien Cristau Reviewed-by: Alan Coopersmith Reviewed-by: Matthieu Herrb commit 17105faffcb4533da71f0d3d17fd40a64b6faf50 Author: Branden Robinson Date: Tue Jan 5 16:40:21 2010 +0000 Always attempt to write data to the auth file Actually attempt to write data to the auth file in SaveServerAuthorizations(); that way we detect problems like ENOSPC (full filesystem, user over quota) early enough to do something about it. (See Debian #217505, #253480) Forward-ported by Julien Cristau . Signed-off-by: Julien Cristau Reviewed-by: Alan Coopersmith Reviewed-by: Matthieu Herrb commit 11d6aa0b392daef2900681b70960d8be4ada89a9 Author: Branden Robinson Date: Tue Jan 5 16:40:21 2010 +0000 Change openFiles() to avoid race-based symlink attacks. Forward-ported by Julien Cristau . Signed-off-by: Julien Cristau Reviewed-by: Alan Coopersmith Reviewed-by: Matthieu Herrb commit cd6b6d5f78e92725d6466d138f5441d791e58212 Author: Branden Robinson Date: Tue Jan 5 16:40:21 2010 +0000 downgrade an error to info message During normal xdm shutdown, killed local X servers can be zombies; this is not an error. Forward-ported by David Nusinow, Eugene Konev and Julien Cristau Signed-off-by: Julien Cristau Reviewed-by: Alan Coopersmith Reviewed-by: Matthieu Herrb commit ecf015a4e78b96af913c1620d542c8e356f2a3d0 Author: Dmitry V. Levin Date: Mon Jan 11 23:09:47 2010 +0000 Call openlog(3) early Before this change, openlog(3) used to be called by greeter which could be built as a dynamically loadable plugin. In the latter case, the ident string passed to openlog(3) resides in a dynamically mapped memory region that is unmapped later when the plugin is unloaded. This can cause fatal problems in some environments. For example, in any GNU/Linux system with PAM support enabled an implicit syslog(3) call made by a PAM module after plugin unload causes attempt to access already unmapped memory, followed by instant crash. It is a common practice to call openlog(3) before the first syslog(3) call, including implicit calls that could be made e.g. by PAM. Also, openlog(3) LOG_ODELAY flag is redundant. Fixes ALT Linux Bug #22362 Fixes FreeDesktop Bug #24589 Reported-by: Martin Mokrejš Reported-by: Denis Kirienko Patch-by: Oleg Zenin Signed-off-by: Dmitry V. Levin Signed-off-by: Alan Coopersmith commit 9142a99cedc99277319e56f132077c1263e1eea8 Author: Gaetan Nadon Date: Sat Dec 19 20:48:47 2009 -0500 configure.ac: use backticks rather than $() for cmd subs Use "$PKG_CONFIG" rather than hard coded "pkg-config" Signed-off-by: Gaetan Nadon commit 989d892443b9d6e52313bf6f4a8606f8749e218d Author: Christoph Bartoschek Date: Mon Nov 30 13:34:30 2009 +0100 XDM: Add support for clients that sent ipv4 addresses to a dual-stacked host If a client sends an ipv4 address to a dual-stacked xdm that is bound to a ipv6 socket in a forward request, then the packet was silently discarded. Now the address is encapsulated as a ipv4-mapped address and a response is send back. Signed-off-by: Adam Jackson commit bad944beb34a988a12a9e18a2f4c42dc59a916a5 Author: Gaetan Nadon Date: Sun Nov 29 10:54:01 2009 -0500 configure.ac: restore correct order for XORG_DEFAULT_OPTIONS It must be following AC_USE_SYSTEM_EXTENSION commit a9ca4d452326b0dafbf1b6f828b53fd0ddd43168 Author: Gaetan Nadon Date: Thu Nov 26 09:19:53 2009 -0500 Makefile.am: add ChangeLog and INSTALL on MAINTAINERCLEANFILES Now that the INSTALL file is generated. Allows running make maintainer-clean. commit a4a8f7b83afc9a46bc989c0eeb528a46b3a1db5d Author: Gaetan Nadon Date: Wed Oct 28 14:09:08 2009 -0400 INSTALL, NEWS, README or AUTHORS files are missing/incorrect #24206 Add missing INSTALL file. Use standard GNU file on building tarball README may have been updated Remove AUTHORS file as it is empty and no content available yet. Remove NEWS file as it is empty and no content available yet. commit 2d4c65a3e62c00e7907dc3f8929cbf8989fc783d Author: Gaetan Nadon Date: Tue Oct 27 15:07:24 2009 -0400 Deploy the new XORG_DEFAULT_OPTIONS #24242 This macro aggregate a number of existing macros that sets commmon X.Org components configuration options. It shields the configuration file from future changes. commit f33e95d44bd378a4a7632f6b591e21b23a861486 Author: Gaetan Nadon Date: Mon Oct 26 22:08:38 2009 -0400 Makefile.am: ChangeLog not required: EXTRA_DIST or *CLEANFILES #24432 ChangeLog filename is known to Automake and requires no further coding in the makefile. commit 8c251b945f57923a37a34219589ac31227ab65df Author: Gaetan Nadon Date: Thu Oct 22 15:47:23 2009 -0400 .gitignore: use common defaults with custom section # 24239 Using common defaults will reduce errors and maintenance. Only the very small or inexistent custom section need periodic maintenance when the structure of the component changes. Do not edit defaults. commit 4de08979f8a77f895919145aa8f5db1b90853537 Author: Alan Coopersmith Date: Thu Sep 24 13:54:40 2009 -0700 Correct default greeterLib path in man page Signed-off-by: Alan Coopersmith commit 1ce3159739800fd7a93d51a378d7dbb3e0b755a5 Author: Martin Dickopp Date: Tue Sep 22 20:16:37 2009 -0700 Debian bug 525596: "Login incorrect" only partially cleared on next login http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=525596 Signed-off-by: Alan Coopersmith commit 61f5e8ee407d361bc10d704ab67a828c54678bfa Author: Georgy A. Shepelev Date: Tue Sep 22 16:58:40 2009 +0400 The whole widget borders width could not be set to zero. Signed-off-by: Georgy A. Shepelev Tested-by: Georgy A. Shepelev Signed-off-by: Alan Coopersmith commit 748cfcc771c7f599d8087c7aa044bc5ff770da1d Author: Alan Coopersmith Date: Tue Sep 22 13:42:31 2009 -0700 Make parent authdir if needed at startup Allows setting authdir to /var/run/xdm Also refactor directory creation code for less duplication Signed-off-by: Alan Coopersmith commit 619af82effb9125c904d34c9fbc4bf93385d7b9e Author: Alan Coopersmith Date: Tue Sep 22 13:41:38 2009 -0700 Create piddir if needed on startup Allows setting piddir to /var/run/xdm/ Signed-off-by: Alan Coopersmith commit 6061722888eab858888dac2499194393299872e4 Author: Alan Coopersmith Date: Fri Sep 18 15:31:50 2009 -0700 Version bump: 1.1.9 Signed-off-by: Alan Coopersmith commit c058aa698b6ddddd4c11608ca412b73d1ffd78d2 Author: Alan Coopersmith Date: Thu Sep 17 19:41:10 2009 -0700 Fill in COPYING file Signed-off-by: Alan Coopersmith commit 3a87227bb357ac9523f853fca84ebde3129e2f05 Author: Alan Coopersmith Date: Thu Sep 17 19:11:52 2009 -0700 Log errors when failing to make authentication dirs/files Signed-off-by: Alan Coopersmith commit da3cfcdd197bd900633c563412685315316804f4 Author: Alan Coopersmith Date: Thu Sep 17 18:33:54 2009 -0700 Refactor & constify error logging code Signed-off-by: Alan Coopersmith commit a7e166298a94c012420713dbfcd0b1628f5c7062 Author: Alan Coopersmith Date: Thu Sep 17 18:08:06 2009 -0700 Unrecognized argument errors shouldn't print xdm error header repeatedly Add LogAppend function to append to previous LogError/LogInfo without repeating the xdm error message header. Signed-off-by: Alan Coopersmith commit e60cf4a084951e697516a6c26dcb5ad14e6f14b8 Author: Alan Coopersmith Date: Fri Sep 11 10:40:05 2009 -0700 Replace -D_XOPEN_SOURCE & -D_BSD_SOURCE with AC_USE_SYSTEM_EXTENSIONS Signed-off-by: Alan Coopersmith Acked-by: Julien Cristau commit 69fc0647bed461a19cf99f4d362a44df8c18de38 Author: Alan Coopersmith Date: Fri Sep 11 09:15:31 2009 -0700 Add support for AM_SILENT_RULES for building files with cpp Signed-off-by: Alan Coopersmith commit 3d51edf9d96f8adcb6f2ab50f4960aa9ecc76afe Author: Alan Coopersmith Date: Fri Sep 11 08:31:55 2009 -0700 Update to using xorg-macros 1.3, including XORG_DEFAULT_OPTIONS Also move CWARNFLAGS addition to CFLAGS from configure.ac to Makefile.am's Signed-off-by: Alan Coopersmith commit a57a7be5962f6f9536ab97751b177575a4884bd0 Author: Alan Coopersmith Date: Tue Aug 18 21:03:54 2009 -0700 Treat all 127.0.0.0/8 addresses as localhost Similar fix to http://bugs.freedesktop.org/show_bug.cgi?id=23329 Signed-off-by: Alan Coopersmith commit a9040b281062ddabcfb2cfdfc37e431b047531b2 Author: Alan Coopersmith Date: Wed Jul 29 11:16:29 2009 -0700 Set utmp/wtmp paths via configure instead of hardcoding them Signed-off-by: Alan Coopersmith commit cafa4376f4761c2d565b2c1deeb7dbfb553d7045 Author: Alan Coopersmith Date: Tue Jul 28 14:31:52 2009 -0700 Truncate pid file before writing new pid to it Prevents trailing garbage in the file if the new pid has fewer digits than the previous pid. (Originally reported against Solaris dtlogin as Sun bug 6627150) Signed-off-by: Alan Coopersmith commit 500775eb145372c5dcbc6e9814858d01730900c7 Author: Alan Coopersmith Date: Tue Jul 28 12:58:58 2009 -0700 Continue processing Xaccess after unresolvable host entry found If there is an unresolvable host entry in Xaccess file, XDMCP access from the hosts whose entries are specified after the unresolvable host in Xaccess were rejected. (Originally reported against dtlogin as Solaris bug 6259901.) Signed-off-by: Alan Coopersmith commit 58021c21c28fdb4949d44aa92e68874155842ccc Author: Alan Coopersmith Date: Tue Jul 28 08:36:10 2009 -0700 Do a better job of getting user name for failed login log when using PAM Check to see if username is filled in before calling FailedError, and fill it in if it's not. Call FailedError before calling pam_end, so we don't reference a username that may have been freed already. Signed-off-by: Alan Coopersmith commit a3f1f5f5b8b3a070de6d9510f588b39f5ebcc0fc Author: Jeff Chua Date: Mon Jul 20 22:21:46 2009 +0800 xdm compile failed due to asprintf() xdm no longer compiles due to recent commit 56a14b8a1f4d3aa883485b794c818581b8f07cd8 that changed to use asprintf(). There is an additional right-bracket that causes the problem. Signed-off-by: Alan Coopersmith commit 2f5bd6ea016a6405208c91c976a16a672cc04184 Author: Branden Robinson Date: Fri Jul 17 23:07:39 2009 -0700 Add RemovePid() function, and register it with atexit() Debian bug#213076 Forward-ported by David Nusinow, Eugene Konev and Julien Cristau. commit ec3152fbba9ee39bbb069913e76e9d165001f98a Author: Branden Robinson Date: Fri Jul 17 23:06:46 2009 -0700 Use xdm's _SysErrorMsg() function instead of strerror() commit 18f286641afbe1d3b61abd31d93c0ae8acb375e9 Author: Branden Robinson Date: Fri Jul 17 22:51:04 2009 -0700 Use _SysErrorMsg() in the log message in various error conditions. Change LogError() invocations to use _SysErrorMsg() where errno might be set (and not clobbered by intermediate calls). Also make LogError() the first thing we do after an error condition in those cases. Forward-ported by David Nusinow, Eugene Konev and Julien Cristau. Signed-off-by: Alan Coopersmith commit 8d15af786d96bb70aceca116a588c2a4b7c45d63 Author: Branden Robinson Date: Fri Jul 17 22:42:40 2009 -0700 Use xdm's _SysErrorMsg() function instead of merely printing errno commit d6faa3c02a6f61c8d01accd0fcead28c39673e32 Author: Branden Robinson Date: Fri Jul 17 22:42:08 2009 -0700 session.c: Add more debugging to execute() [jcristau@debian.org: save errno before calling Debug() in one place] commit 2d6d2f121bffb378676f422b44d37534c8c5d53b Author: Branden Robinson Date: Fri Jul 17 22:41:31 2009 -0700 Add some more log and debug messages Add log messages for xdm startup, shutdown, and normal exit. Add a debugging message when xdm enters its main loop. commit 72240433a85410e68a3b6705e097337ff985ae90 Author: Julien Cristau Date: Wed Aug 20 01:30:59 2008 +0200 Call InitErrorLog() right after BecomeDaemon() The latter points stderr to /dev/null, so the sooner we open the log after that, the better. commit 6dfbdf2823dc50c6b0ff24afbc58c67dc1651bef Author: Branden Robinson Date: Fri Jul 17 22:33:55 2009 -0700 spelling fix commit 195a991ef5e5d578d3499a5496d064d1b9b1dc7f Author: Alan Coopersmith Date: Fri Jul 17 22:29:26 2009 -0700 Clarify comment/#ifdefs for USE_SIOCGLIFCONF Signed-off-by: Alan Coopersmith commit 6770509fa149cf8bc148e2ed3c8e11e0b83a4ee1 Author: Alan Coopersmith Date: Fri Jul 17 22:21:25 2009 -0700 Remove #ifdef Lynx blocks Signed-off-by: Alan Coopersmith commit 3beb4d278caa281ea8ebad55ae2f45ea0d46a6e6 Author: Alan Coopersmith Date: Fri Jul 17 22:14:42 2009 -0700 Use imdent to show cpp macro nesting more clearly Also strip trailing whitespace to make git happier. While many lines are changes, "git diff -w" shows no changes other than pure whitespace. Signed-off-by: Alan Coopersmith commit b80b263f964031b1edef0a5e0a77a6615dc4be82 Author: Alan Coopersmith Date: Fri Jul 17 21:58:11 2009 -0700 Delete old A/UX (#ifdef macII) code Signed-off-by: Alan Coopersmith commit 70b7a9a7a83b042f46abd50bbe21b0522a0dd9a5 Author: Alan Coopersmith Date: Fri Jul 17 21:46:46 2009 -0700 malloc(strlen()); strcpy() -> strdup() Signed-off-by: Alan Coopersmith commit 7221da99593ee2fe1943250523965b70d59dbf56 Author: Alan Coopersmith Date: Fri Jul 17 21:17:36 2009 -0700 Documentation improvements - Remove references to setting build-time defaults via Imake configuration - Show actual default $PATH & authDir settings in man page - Whitespace & minor formatting fixes in man page - Update man page info on multicast addresses from RFC 2373 to RFC 4291 - Add notes on mailing list, git repo, and patches to README Signed-off-by: Alan Coopersmith commit 0c57a398cef50d13a821ad341ffb15ab0cbd2bad Author: Matěj Cepl Date: Fri Jul 17 20:59:48 2009 -0700 Add variable DisplayManager.authDir to xdm-config (Fedora bug 388431) Fedora patch xdm-1.1.6-authDir-var-bug388431.patch Signed-off-by: Alan Coopersmith commit 56a14b8a1f4d3aa883485b794c818581b8f07cd8 Author: Alan Coopersmith Date: Fri Jul 17 20:37:51 2009 -0700 sprintf -> snprintf/asprintf conversions Signed-off-by: Alan Coopersmith commit a74131c41c63cbe5861b9550dfa7a921ec601c87 Author: Alan Coopersmith Date: Fri Jul 17 18:34:19 2009 -0700 Remove OS/2's duplicate copy of default path definitions in resource.c Signed-off-by: Alan Coopersmith commit 8463017f7de43fe0a8ec144faca6bbf43168ebf9 Author: Alan Coopersmith Date: Fri Jul 17 15:19:40 2009 -0700 Replace FORCE_CURSOR_FLASH code with simpler cursor update for passwd field Signed-off-by: Alan Coopersmith commit 36fc6f22a529b2e9fc8dadfe944a10d54f4d3654 Author: Alan Coopersmith Date: Thu Jul 16 19:35:24 2009 -0700 Move xdmcp ARRAY initializators to declarations Signed-off-by: Alan Coopersmith commit 1e23dd0d37c276eea9c883270076926f5a2fee3f Author: Alan Coopersmith Date: Thu Jul 16 19:10:30 2009 -0700 Remove RCS Ids Signed-off-by: Alan Coopersmith commit b21117d4eaaa7b5886c139f06b8acae9890448c2 Author: Alan Coopersmith Date: Tue May 19 01:33:41 2009 -0700 Update AC_DEFINE_DIR to latest version from Autoconf Archive commit 332bd687a265642d17109eafb2d183887a53d739 Author: Matthieu Herrb Date: Fri Jan 30 22:48:17 2009 +0100 getLocalAddress(): return 127.0.0.1 if the hostname doesn't resolve. This code already does this if IPv6 support is compiled in. It was dereferencing a NULL pointer in the IPv4 only case. commit a4f47b755ae85bf3e35a3376fcf44ace67c38767 Author: Matthieu Herrb Date: Fri Jan 30 10:44:01 2009 +0100 Remove RCS Id and put some comment here. commit 7a44f525570af2e1d24893635c85cd86091c5503 Author: Paulo Cesar Pereira de Andrade Date: Tue Jan 20 16:08:34 2009 -0200 Ansification and compile warning fixes. This also uses XORG_CHANGELOG and XORG_CWARNFLAGS, corrects make distcheck and most gcc 4.3 and sparse warnings. Remaining warning is due to passing read or write as function pointers in the format ssize_t (*)(int, void *, size_t), as it is const for write, but not for read. commit b4dc9afe20ab9c4ddec29a7357e147258e34bb67 Author: Julien Cristau Date: Mon Mar 10 17:51:15 2008 +0100 Add support for syslog on more than openbsd. Also use LOG_AUTHPRIV by default, if that exists. commit 4fbd4bfcca12a91dacb25fb08a6a3b07822b5845 Author: James Cloos Date: Wed Aug 20 10:32:50 2008 -0400 xaw8 is gone, use xaw7 commit b73d0c91d32bf0aa60aa5ce2bbbd4468ce21a445 Author: David Sainty Date: Mon Aug 4 19:06:43 2008 -0700 Bug 16356: xdm Xstartup/Xreset configuration files malconstructed by cpp X.Org Bug #16356 Signed-off-by: Alan Coopersmith commit c9cdec25130bc957b584ec15187e068f9c08862d Author: Adam Jackson Date: Wed May 21 14:24:58 2008 -0400 xdm 1.1.8 commit 5f94cf40697145678c96e9899df69ad2550a4509 Author: Julien Cristau Date: Thu May 15 16:52:09 2008 +0200 $(builddir) is the current directory Apparently automake doesn't always export the builddir variable. This fixes the previous commit. commit 46d72e82f4069d281f61a9fdbae11157241f3553 Author: Samuel Thibault Date: Tue May 6 17:57:22 2008 -0700 Bug 10145: xdm passes file descriptors to children X.Org Bugzilla #10145 Patch #14644 Signed-off-by: Alan Coopersmith commit b4ac133b92e08a34054d0af9481ab59b03571818 Author: Julien Cristau Date: Sun Apr 20 19:32:12 2008 +0200 Fix build with builddir != srcdir commit 1b14e9391500d06dd0b61967db8099c3cf27f90c Author: Jeremy Huddleston Date: Thu Mar 27 19:57:08 2008 -0700 Build fix for case-insensitive file systems commit c0f0d3adebb9b133e26a6e25738cfe38b36e5314 Author: Jeremy Huddleston Date: Thu Mar 27 19:52:33 2008 -0700 Added include of pwd.h so we build correctly on OS-X - see xorg mailing list commit c2de936fe580d82da3c5b3590a1acb9e28ec68c1 Author: Julien Cristau Date: Sat Mar 8 06:40:14 2008 +0100 Fix installation of app-defaults Add a configure option for appdefaultdir, and use it for make distcheck, because it wants everything under $prefix. By default, still use `pkg-config --variable=appdefaultdir xt'. commit f2f2eed7c284ced3ddc3fe3451ec7a8af9dfdbb4 Author: Matthieu Herrb Date: Sat Mar 8 22:21:57 2008 +0100 README: nuke RCS Id commit 576861d7e6158790e18ae79b8d566919b88d0cae Author: Adam Jackson Date: Fri Mar 7 17:12:33 2008 -0500 xdm 1.1.7 commit 996fea2fb1ae1e419e673b89cc3778e371a29324 Author: Adam Jackson Date: Fri Mar 7 17:10:30 2008 -0500 Fix distcheck. commit 87a8f18c334b3e5819f92d0f8f37cc41987486d4 Author: Jeremy Huddleston Date: Thu Dec 20 19:11:53 2007 -0800 Darwin doesn't need __DARWIN__ anymore. commit 28f4ded22488ce8542ff8b9871f6b4e04614058d Author: Alan Coopersmith Date: Fri Sep 21 11:03:54 2007 -0700 Debian bug #440389: 800x600 settings got lost, screen now too wide Debian bug #440389 When deleting the XPM #ifdefs, a set of #if WIDTH < 800 resources got accidentally deleted as well. (Cause & fix found by Brice Goglin) commit 923176024d3d6b7f5b392b4f9a07cce8c6ed3823 Author: Alan Coopersmith Date: Mon Aug 27 14:17:13 2007 -0700 Restore #endif accidentally removed in d0d4581be22aba9021c5a672bd9e5ba719961e29 commit e775ab1778850663a755279470d3ad6a2c9c0054 Author: Alan Coopersmith Date: Thu Aug 16 14:47:17 2007 -0700 Version bump: 1.1.6 commit 298811a10ee1b72c553d18cc40bdfde17afb14e8 Author: Luca Capello Date: Sun Jul 2 18:57:05 2006 +0200 Debian Bug #376391: xdm manpage refers to non-existent section 'Typical Usage' commit 593788896cdba598ceaa5fbf9e4d214583ffb6ed Author: Brice Goglin Date: Wed Aug 15 18:38:53 2007 -0700 Debian Bug #437961: loading Xresources fails because bindir/xrdb does not exist commit ef1be3254966018fede7c33dea2f41b9351ef699 Author: Alan Coopersmith Date: Fri Aug 10 10:43:10 2007 -0700 Version bump: 1.1.5 commit 3ed70d13a6957c2434753f32d388888eae079d82 Author: Alan Coopersmith Date: Wed Jul 25 17:07:33 2007 -0700 Update AC_DEFINE_DIR to autoconf-2.60-compatible version commit dd05076f290b1995f71627324cc74053c870ac21 Author: Alan Coopersmith Date: Wed Jul 25 17:03:56 2007 -0700 Add AM_PROG_CC_C_O to clear automake-1.10 warning Makefile.am:149: compiling `chooser.c' with per-target flags requires `AM_PROG_CC_C_O' in `configure.ac' commit 29dc5825782adf929bce41a18e6a6881ef975d22 Author: Alan Coopersmith Date: Wed Jul 25 17:00:39 2007 -0700 Bug #10530: xdm's path to xrdb could be configurable at compile time Add --with-xrdb=path & --with-default-session=command configure options X.Org Bug #10530: commit 2719e18c3782c5b21f712711b4198a5bb55f5473 Author: Alan Coopersmith Date: Fri Jun 15 20:14:21 2007 -0700 Set default cursor for entire root window, not just greeter commit d0d4581be22aba9021c5a672bd9e5ba719961e29 Author: Alan Coopersmith Date: Fri Jun 15 19:43:46 2007 -0700 Make #ifdef XPM only control whether XPM pixmap logo is shown Make 3D look-and-feel independent of XPM commit 188415ebf07ff8a25ac663c37615269cd1a741a4 Author: Alan Coopersmith Date: Fri Jun 15 19:23:05 2007 -0700 Set Xcursor theme to whiteglass in default login screen resources commit f8585c60831a8e5ddebce18bdd7e78d217a822c5 Author: Alan Coopersmith Date: Fri Jun 15 18:36:15 2007 -0700 X.Org Bug #10992: xlogin crashes if window size is too small X.Org Bugzilla #10992 commit 0ce4128e19f9fac9a565cce42a6a575486d371a5 Author: Alan Coopersmith Date: Fri Jun 15 14:24:59 2007 -0700 Add --enable-xdm-auth/--disable-xdm-auth to configure options commit 8e0b23e24556fb6c6b9943bf3747e70b245fc7aa Author: Chip Coldwell Date: Thu Jun 24 09:56:19 2004 -0700 X.Org Bug 10632 / Debian Bug 256299: race condition in policy.c:Willing() X.Org Bugzilla #10632 Reported upstream from Debian Bug #256299 commit a8927ee05efba3afe955731bab5d633879c39833 Author: Alan Coopersmith Date: Thu May 31 17:11:15 2007 -0700 Document more of the greeter resources in xdm man page commit 35f563369470139665498640f4cda23d1227073b Author: Alan Coopersmith Date: Tue May 29 19:57:29 2007 -0700 Bug #11096: xdm(1) manpage should document Xft-related properties X.Org Bugzilla #11096 Added descriptions of the Xft *face resources and changed the core fonts *font resource descriptions to match. Also cleaned up various other descriptions to make it easier for users customizing the look of the login screen. commit e7f1c433dc0bd8e864cec68dbc120f27696bbba6 Author: Alan Coopersmith Date: Thu May 24 10:32:32 2007 -0700 Bug #11020: xdm doesn't set SSH_AUTH_SOCK even though using with pam_ssh Wasn't calling pam_setcred()/pam_getenvlist() if setusercontext() was present X.Org Bugzilla #11020: commit 677d028e41e890103679eec92b58044420b9b4c5 Author: Alan Coopersmith Date: Tue Feb 6 11:45:41 2007 -0800 Version bump: 1.1.4 commit 6e2362e825dfec6df73f1338088a850225ed92d2 Author: Alan Coopersmith Date: Tue Feb 6 11:34:30 2007 -0800 Rearrange checks for maximum username & password length Give preference to standard definitions, use less hardcoded knowledge about which platforms provide other definitions. commit f6ab9602b8418b035f12da171a7d6edfed464aee Author: Alan Coopersmith Date: Fri Feb 2 17:27:46 2007 -0800 Reset username prompt to default string at start of PAM loop Fixes bug reported by Stefan Dirsch in http://lists.freedesktop.org/archives/xorg/2007-February/021510.html commit 3f1611b69f6b24184aa4b07c796526f49fa0db5f Author: Alan Coopersmith Date: Fri Feb 2 13:20:52 2007 -0800 Make sure windowPath is properly initialized & freed commit 5f0f8c00f47e778c59ae22bf685c97756456b2cd Author: Samuel Thibault Date: Thu Feb 1 17:16:41 2007 -0800 Bug 8014: xdm should set the WINDOWPATH environment variable X.Org Bug #8014: Patch #6702: commit 450e9eb2725be6ead1c6d3e5477b737ded04070b Author: Alan Coopersmith Date: Thu Feb 1 15:23:12 2007 -0800 Bug #8561: xdm painfully slow at cursor redraws Made code that waited for cursor redraws to appear onscreen conditional on FORCE_CURSOR_FLASH #define, which is off by default. commit e4274acc8cb7354cf191f91a8ed2054cb7af9916 Author: Alan Coopersmith Date: Tue Jan 2 14:40:15 2007 -0800 Add ChangeLog to MAINTAINERCLEANFILES commit 9554052c14fc09ed1894580620ca94428f38e59b Author: Daniel Stone Date: Thu Dec 21 14:58:03 2006 +0200 config: quote cpp arguments (bug #9414) Quote all arguments given to cpp. commit 0128497fac0794d947fa44b433550fe064905d8d Author: Daniel Stone Date: Sat Dec 16 01:38:30 2006 +0200 xdm 1.1.3 commit 3bc9148509a058647a9c43d0e2668c94ac579884 Author: Daniel Stone Date: Wed Dec 6 19:01:52 2006 +0200 Makefile.am: make ChangeLog hook safer Make ChangeLog hook as safe as possible. commit 75a8fce621adecd50db129c839a578df630137db Author: Daniel Stone Date: Thu Nov 30 19:49:31 2006 +0200 bump to 1.1.2 commit c8612093ba0a67c1a161111d58aac9956b9c5320 Author: J.P. Larocque Date: Mon Nov 20 11:06:18 2006 -0800 Bug 7317: xfs doesn't build on some GLIBC based systems: _XOPEN_SOURCE undefined Bug 7317: commit 15e5c60cced750559853ca7e9bddcd6b7f1dd3f9 Author: Alan Coopersmith Date: Mon Nov 13 14:51:16 2006 -0800 Bump version number to 1.1.1 commit 623dacd509bd6c0c1f0c2c424933818ff34788ca Author: Vickenty Fesunov Date: Mon Nov 13 14:48:02 2006 -0800 Bug 8995: Copying address into in6_addr instead of in6_addr.sin6_addr in forward_respond() Bugzilla #8995 Patch #7759 commit 37f9293e3cc00411d8d335ce729d18995bb9ce59 Author: Alan Coopersmith Date: Mon Nov 6 14:08:15 2006 -0800 Fill in paths at build time in Xreset & Xstartup Stop hardcoding /usr/X11R6/bin/sessreg and instead fill in paths like other config files from directories passed via configure. commit 0e0221a70543ba5f2aa7ce188e2dc9544bac96bd Author: Darrel Goeddel Date: Wed Oct 18 18:59:02 2006 -0700 Set PAM_TTY for local displays commit 698ffcff29d4c574b155451342bc6e3b9ee07287 Author: Alan Coopersmith Date: Tue Oct 3 18:32:54 2006 -0700 Bump version number to 1.1.0 commit 46fea537186aa57d803262bf5f504f7041a7d97e Author: Alan Coopersmith Date: Tue Oct 3 18:21:15 2006 -0700 Replace static ChangeLog with dist-hook to generate from git log commit f97db135e818ea04735e1fbbaea2e7d3dac9c872 Author: Alan Coopersmith Date: Tue Oct 3 18:11:03 2006 -0700 Replace static ChangeLog with dist-hook to generate from git log commit 3349ab7b6c2b9ff6ad39da6d29b6aa1250f96cd9 Author: Alan Coopersmith Date: Mon Aug 14 13:48:19 2006 -0700 Draw text with Xft in greeter window (Includes portions copied from Keith Packard's Xft conversion of xclock) commit 0e47586fe5c76d7804368c4536e66ec610978e38 Author: Alan Coopersmith Date: Mon Aug 14 11:02:51 2006 -0700 SetPrompt takes LOGIN_* not PAM_* constants for type argument commit 929d2d81827325c2736f6ccf47d017364153b3a7 Author: Alan Coopersmith Date: Mon Aug 14 10:56:50 2006 -0700 Include display number in Xserver arguments commit 2fbac8d6d0fd9bfebcd30a128cfef4131149e735 Author: Alan Coopersmith Date: Fri Aug 11 14:04:58 2006 -0700 Sun bug 6459557: remote logins to xdm fail since recent PAM fixes When stripping : off the end of the display name so that we can pass the remote hostname to PAM, make sure we modify the copy we made for PAM, not the original which is used to set $DISPLAY for the session being created. commit be9b2e85f579c5eda7a8868ee9ebf0b268c5a181 Author: Alan Coopersmith Date: Fri Jul 14 15:25:19 2006 -0700 Delete unused Panic() function commit 2094955be1ef94a0ba3f7dcf64ae04c9575dbd9c Author: Alan Coopersmith Date: Fri Jul 14 15:11:08 2006 -0700 Use pid_t instead of int when working with fork/wait/etc. (clear more lint warnings) commit 1abe7027403ecf00b846c675fac27c2d86ebd9d4 Author: Alan Coopersmith Date: Fri Jul 14 14:01:18 2006 -0700 Store return values from umask in mode_t instead of int (clear lint warnings) commit 5283b118b4bfdb1a85356147701f602b884c342b Author: Alan Coopersmith Date: Fri Jul 14 13:05:52 2006 -0700 Fix many sparse warnings of: Using plain integer as NULL pointer Also fixes Login.c:1329:5: warning: mixing declarations and code from extra ; commit 41211f8c849de67cebeb9d9f7516eb5a4a7eb3cf Author: Alan Coopersmith Date: Fri Jul 14 13:02:02 2006 -0700 Add XORG_WITH_LINT & lint targets for checking code with lint/sparse/etc. commit bfe7bc6a04d468f7943ebed9a7ea571cbf916d9e Author: Alan Coopersmith Date: Fri Jul 14 11:40:20 2006 -0700 Add *~ to .gitignore to skip emacs droppings commit 1e19a9746ffa570f81346307b1eb32257a0bb24a Author: Alan Coopersmith Date: Fri Jul 14 11:38:39 2006 -0700 renamed: .cvsignore -> .gitignore commit aee9b7f645c12a2a3bc6605726669dbb7b5f3985 Author: Alan Coopersmith Date: Tue Jun 27 16:33:25 2006 +0000 Bugzilla #7317 xdm needs to define _XOPEN_SOURCE to build on Hurd (J.P. Larocque) commit 6329bf48b0f775335e552967622bf53912131edb Author: Alan Coopersmith Date: Tue Jun 27 01:25:40 2006 +0000 Bugzilla #7318 Patch #6032 xdm crashes on Hurd because of incongruity in dlfuncs (J.P. Larocque) commit 6bf94d0ed871db12e8e5aa48200ce3b548895b8f Author: Alan Coopersmith Date: Mon Jun 26 23:56:06 2006 +0000 Bugzilla #7332 Patch #6046 (1) Xdm compiled with IPv6 support failed to accept any chooser connections (even when only using IPv4). (2) There should be a one-to-one correspondence between successful getaddrinfo calls and freeaddrinfo calls. (Peter Breitenlohner) commit b80ae0aa74cfd9d168f4e100e0fea8fef240500f Author: Matthieu Herrb Date: Tue Jun 20 19:25:51 2006 +0000 Check setuid() return value. Bugzilla #7116. commit 57e927d7340494bb5fdd73c04c9e1f33379b9b75 Author: Alan Coopersmith Date: Tue Jun 20 01:50:35 2006 +0000 Initialize manufacturerDisplayID.length to 0 too. commit fe7e9b5b69e42b92a1e0aac4faef8c1c9d21ac96 Author: Alan Coopersmith Date: Sat Jun 3 01:13:44 2006 +0000 Mark GreetUser (called from xdm) as _X_EXPORT. Make all other non-static functions in libXdmGreet _X_INTERNAL. commit aae2d2d25d7423c99baadb724ff7722cafdcf095 Author: Alan Coopersmith Date: Sat Jun 3 01:01:21 2006 +0000 Replace old Imake-based SIGNALRETURNSINT with AC_TYPE_SIGNAL util.c Replace old Imake #ifdefs with AC_CHECK_FUNCS([sigaction]) commit ec8fdcf0cff01a504bfbf096194012fff997f4ca Author: Alan Coopersmith Date: Sat Jun 3 00:06:46 2006 +0000 Make initial pass at an AUTHORS list. commit 4010a63ee6e05bee51208d667a0dc7f01f916af8 Author: Alan Coopersmith Date: Sat Jun 3 00:05:24 2006 +0000 Convert PAM code to use full PAM conversation. Modify greeter to allow PAM to prompt for more than just username and password. Rely on PAM to initialize Secure RPC & Kerberos credentials when it is being used. (Based on work begun for Sun bug #6398796 "Solaris-10: Unable to login thru xdm once password is aged") commit 1f7dab056c661af97ca7c6a7b61a87b26ca3fa36 Author: Alan Coopersmith Date: Fri Jun 2 23:14:36 2006 +0000 Drop pre-waitpid() support since all POSIX.1-1990 systems have waitpid. commit 2a79e8011cffd6e7a2d4a5c15ad4df8b96e12309 Author: Alan Coopersmith Date: Fri Jun 2 23:12:12 2006 +0000 Bump version to 1.0.99 for 1.1 branch. commit 56ee4c350624f42cbeb7a19656f65a79b74ba53f Author: Alan Coopersmith Date: Thu Apr 27 21:21:15 2006 +0000 Version bump: 1.0.4 commit 1ba990f121143be61eedc530f15ad30ca4d1742f Author: Alan Coopersmith Date: Fri Apr 14 20:17:31 2006 +0000 Sun bug #6413255: xdm should check for uid 0, not for username of "root", when doing non-console login check commit aa1a1388081db6f1592db823c69bd699ca172683 Author: Alan Coopersmith Date: Fri Apr 14 02:52:02 2006 +0000 Add AC_C_INLINE so we can use "inline" keyword Add "inline" to max function definition commit 03fad3472eabe457a6bc37989edd875f081b529b Author: Alan Coopersmith Date: Wed Apr 12 01:57:46 2006 +0000 When clearing username & password buffers, zero out the entire buffer, not just the first byte, for reduced risk of leaking passwords into core dumps. commit 3960bb1666e3d0ec2da3cd5ea8492792290018c7 Author: Alan Coopersmith Date: Wed Apr 12 01:55:05 2006 +0000 ChangeLog for last commit commit 2900b8984d8fdce182b87f0ce7a2f5813ea0b53f Author: Alan Coopersmith Date: Sat Apr 8 00:22:23 2006 +0000 Xorg bug #4765 Patch #3555 xdm doesn't work with the pam_krb5 module (call pam_getenvlist after pam_setcred) (Constantine Sapuntzakis) commit c9fcce730483358594c9556426098ac3325da47f Author: Alan Coopersmith Date: Fri Mar 31 02:19:01 2006 +0000 Version bump: 1.0.3 commit e6e6b9960262ab30d64486898fc147c7010a5559 Author: Alan Coopersmith Date: Thu Mar 30 21:14:31 2006 +0000 Drop all setpgrp/setpgid silliness and just use setsid everywhere. (Assumes all platforms are at least POSIX.1-1990 compliant.) Check for error return from daemon() function. commit 4fad29bad3e06127b93c8cef3761b40472df6bb7 Author: Alan Coopersmith Date: Mon Mar 27 23:59:21 2006 +0000 Version bump: 1.0.2 commit 9609b9f14945b8dc55321a5fee7855f7b1dc9451 Author: Alan Coopersmith Date: Sat Mar 18 03:43:18 2006 +0000 Bug #5898 Use mktemp command to create files safely in TMPDIR or /tmp on systems that have it - don't try to create files there if mktemp is not present. Fix based on NetBSD fix from . commit 5102f671d3f5a4e870e8ea8b78cef953d4f64111 Author: Jeremy C. Reed Date: Thu Mar 16 21:56:24 2006 +0000 DragonFly is a BSD, so is CSRG_BASED and use su with -m option. commit 4a0e026c04bd1027641670eda68e3a65441d2b63 Author: Alan Coopersmith Date: Thu Mar 16 21:46:55 2006 +0000 Convert checks for , daemon(), and setpgrp arguments to autoconf tests instead of checking OS name #ifdefs. commit 0a224935e64342e3eec055672229212c856ea14b Author: Alan Coopersmith Date: Sat Mar 11 04:07:00 2006 +0000 Coverity ids #722, 723, 724, 725, 726, 727, 728: Need to XtFree the values returned by XawListShowCurrent to plug memory leaks. Coverity id #834: After joining a multicast group, add group pointer to the list of active multicast groups instead of just leaking the group pointer. commit 23198133e90c34508e5d0c0f1314bf167bf3a98c Author: Alan Coopersmith Date: Fri Mar 10 00:48:16 2006 +0000 Coverity ids #7689, 7690, 7691: When malloc fails, don't just print an error and continue on using the NULL pointer, return NULL to the caller. commit 17b0d313c80ca754348ca8b92ce117918a2f8d43 Author: Matthias Hopf Date: Wed Mar 1 15:48:06 2006 +0000 openSUSE bug #142954 Fixed potential segfault on OOM condition. commit 6729f4df2d314a3573f3da7da3fc364cb48685de Author: Alan Coopersmith Date: Sat Feb 25 02:21:51 2006 +0000 Bug #6036 Check for key_setnet declaration before defining it to avoid compiler error of conflicting types on DragonFly BSD commit ebec01137a6b200ee9432faecde5817670b41684 Author: Alan Coopersmith Date: Sat Feb 25 00:58:50 2006 +0000 Bug #6026 Segfault in netaddr.c:ConvertAddr if ifa_addr is NULL (Loser Mcloser ) commit f82da0960018bfa4237d3d8239cf84d880673e6a Author: Jeremy C. Reed Date: Fri Feb 24 21:36:13 2006 +0000 Bug #5897 Create xsession error file with umask 077 instead of chmod a moment later so others can't open first. This was reported by Steven M. Bellovin to NetBSD http://www.netbsd.org/cgi-bin/query-pr-single.pl?number=32804 Reviewed by Alan Coopersmith via xorg_security list. commit 2a01568e61905944a59a7a8b34f22e08ccd25937 Author: Alan Coopersmith Date: Fri Feb 24 18:09:00 2006 +0000 Bug #1391 Patch #4739 xdm hangs in a loop when invalid xpm bitmap is used for logo (Costantino Leandro ) commit 26388c9b82fd29ecde162b81bd59f38827171142 Author: Kevin E Martin Date: Wed Dec 21 02:29:49 2005 +0000 Update package version for X11R7 release. commit b0c37b961844260d75e0bf88354e4fd04c36a4fc Author: Adam Jackson Date: Mon Dec 19 16:22:43 2005 +0000 Stub COPYING files commit 2e78ed332496e323acf63b3783d4818751dcf560 Author: Kevin E Martin Date: Thu Dec 15 00:24:06 2005 +0000 Update package version number for final X11R7 release candidate. commit c8288d472e3c0881a201207140ac51ce713da877 Author: Alan Coopersmith Date: Sun Dec 11 20:46:25 2005 +0000 Bugzilla #5055 Add XDMSCRIPTDIR cpp substitution to allow modular tree builder/packager to decide if scripts should go in config, lib, or data directories. commit 3d1caeec0b120997b5a958bec586c01665516499 Author: Alan Coopersmith Date: Sun Dec 11 20:43:49 2005 +0000 Bugzilla #5055 Add --with-xdmscriptdir to allow builder/packager to decide if scripts should go in config, lib, or data directories. commit af3cf72277abea12541117e7acc9867a7ad48cb7 Author: Kevin E Martin Date: Wed Dec 7 16:17:59 2005 +0000 Change to use the app-defaults default dir configured in libXt. commit 15eddf034f082a10076967e77fd7af5d6a0cca2a Author: Kevin E Martin Date: Tue Dec 6 22:48:20 2005 +0000 Change *man_SOURCES ==> *man_PRE to fix autotools warnings. commit 2824039d6b25007fd597a5fd0823268e193b4810 Author: Kevin E Martin Date: Sat Dec 3 05:49:19 2005 +0000 Update package version number for X11R7 RC3 release. commit eace59cc41e57fd48e22be043cefb5bdee60a0d6 Author: Alan Coopersmith Date: Mon Nov 28 22:01:40 2005 +0000 Change *mandir targets to use new *_MAN_DIR variables set by xorg-macros.m4 update to fix bug #5167 (Linux prefers *.1x man pages in man1 subdir) commit 06dcef110dc99a939ff2cfbc68ba85b4635cb055 Author: Alan Coopersmith Date: Wed Nov 23 19:32:39 2005 +0000 Set HAS_ARC4_RANDOM if arc4random() function is found Set RANDOMMANDEFS to correctly substitute alternate random device/method descriptions in man page. commit 53c306241b93562b3b309072a652c708e87c0850 Author: Alan Coopersmith Date: Tue Nov 22 05:43:52 2005 +0000 Fix file paths in man pages. commit a608715447b1c700c017f80c6ba27ce4dbbac973 Author: Eric Anholt Date: Mon Nov 21 10:34:59 2005 +0000 Another pass at .cvsignores for apps. commit d0149420c83f80cb15151a361b0929d53505d056 Author: Eric Anholt Date: Mon Nov 21 07:21:39 2005 +0000 Bug #5113: The insertion of -lutil into XDM_LIBS ended up having no effect because PKG_CHECK_MODULES(XDM, ...) later overwrote it. So put -lutil into XDM_OS_LIBS and add XDM_OS_LIBS to XDM_LIBS later. commit b4ee0e22b54786e0bb9a5b1c527be2e7f71100ba Author: Eric Anholt Date: Sun Nov 20 22:08:51 2005 +0000 Add/improve .cvsignore files for apps. commit 05b9908f5e7d30df1230cfa872d4022c2fccfc3d Author: Alan Coopersmith Date: Sun Nov 20 04:00:36 2005 +0000 Add dependency on xau. commit 7f31d566014d9e99569e0b93ee93009ec4028e6e Author: Kevin E Martin Date: Sat Nov 19 07:15:36 2005 +0000 Update pkgconfig files to separate library build-time dependencies from application build-time dependencies, and update package deps to work with separate build roots. commit 6ebcb3aab1c6a0c58b6d6d304d7ae61168990c33 Author: Alan Coopersmith Date: Mon Nov 14 04:25:43 2005 +0000 Add --enable-dynamic-greeter flag to allow choosing whether greeter should be built into xdm binary or dynamically loaded libXdmGreet.so object. Add -rdynamic flag to link options when using gcc with dynamic greeter to allow greeter object to reference symbols in xdm. commit f9e6bc3588358c82c9d6e3293cc4eae28567959b Author: Alan Coopersmith Date: Sun Nov 13 01:41:50 2005 +0000 Install xdm man page using APP_MAN_SUFFIX instead of forcing .1 commit 9bccda24de3851829059c224ce94de28066bd8f5 Author: Kevin E Martin Date: Wed Nov 9 21:09:20 2005 +0000 Update package version number for X11R7 RC2 release. commit 515ba1756966081ca3fae0cdd5a776f5a4fc6ad1 Author: Alan Coopersmith Date: Tue Nov 8 07:50:12 2005 +0000 Changes to match bug #3180 checkin to monolith: Generate Xsession from Xsession.cpp Add SHELL_CMD to cpp substitutions configure.ac Set SHELL_CMD to /bin/ksh for sco, /bin/sh for all other OS'es. commit 3834f880ba013be524cd5b4ce4ff75734742ad12 Author: Kean Johnson Date: Tue Nov 8 06:33:32 2005 +0000 See ChangeLog entry 2005-11-07 for details. commit d384b20b3d63f1b28d428f02746d5ec0c1e81a39 Author: Alan Coopersmith Date: Tue Nov 1 16:44:38 2005 +0000 Add AC_DEFINE_DIR calls for the path #defines previously set in RES_DEFINES section of xdm Imakefile. (Some should probably be made settable via configure --with-* flags, but at least they correctly set defaults to match the directories specified to configure now.) commit dc12a42ebd70b24c4d84632fa253cd6e3094cbd2 Author: Kevin E Martin Date: Tue Nov 1 15:05:18 2005 +0000 Update pkgcheck depedencies to work with separate build roots. commit 2b9da10c25ddcc9f098fa9af69e5f560037b5660 Author: Daniel Stone Date: Sun Oct 30 17:25:00 2005 +0000 Add -I$(top_srcdir) to pick up dm{,_error}.h and greet.h. commit 2e06c1273459c14006452b8a483178494a4ba61f Author: Alan Coopersmith Date: Sat Oct 29 01:48:12 2005 +0000 Fix #ifdef statement syntax to clear compiler warning. commit f4a2e78f543a5b8ab5101cd22b625addc12cf6a5 Author: Alan Coopersmith Date: Sat Oct 29 00:05:12 2005 +0000 Add -DGREET_LIB to GREETER_CFLAGS on Solaris & SVR4 (was in #if SVR4 in Imake) Add --with-random-device and checks for /dev/urandom & /dev/random for source of random data for key generation Link libXdmgreet with Xinerama & XPM libraries when using those features. commit 461b7fc37aae3578577a9eab2c9310287af14726 Author: Alan Coopersmith Date: Wed Oct 26 03:21:17 2005 +0000 Use XDMCONFIGDIR for location of configuration files so they can be installed in a directory other than the lib directory. (Only overridable in modular build system at this point.) commit 16917371d7663d59c58dbd27c8592d3b6e8ef078 Author: Alan Coopersmith Date: Wed Oct 26 03:17:17 2005 +0000 Allow overriding directories for xdm scripts/modules & configuration files via configure options --with-xdmlibdir & --with-xdmconfigdir Add libXt and libX11 to dependencies for libXdmgreet. Document default directories & configure options to change them commit eb1ed04945a3af8d04f5441966674486be715036 Author: Alan Coopersmith Date: Wed Oct 26 02:25:02 2005 +0000 We forgot to build the Xdm greeter library. Add it to build and cleanup hardcoded values to find it. commit 1770fc21706c276d051de4dbe8a199f12a06f711 Author: Kevin E Martin Date: Wed Oct 19 02:47:53 2005 +0000 Update package version number for RC1 release. commit 6279ce5e919e7a1a92060b7448c8d68ef6aef8af Author: Alan Coopersmith Date: Tue Oct 18 02:12:17 2005 +0000 Change XCOMM to \&# to allow both cpp & sed to translate correctly. Use XDMPIDDIR instead of XDMDIR when showing location of xdm-pid file in man page. commit fbfdcd1c2e760014c5c0632c785e405f20d759e1 Author: Alan Coopersmith Date: Tue Oct 18 00:32:55 2005 +0000 Change default install dir for app-default files from $(sysconfdir)/X11/app-defaults to $(libdir)/X11/app-defaults to match the monolith & allow localization commit 971fdf46fa6a43b121db4a8e64dcde62dab0a85e Author: Alan Coopersmith Date: Mon Oct 17 20:40:32 2005 +0000 Set XDMPIDDIR in when subsituting variables in man pages commit 1afabc5f0a70fc32581b53eb978f06a30f58fefa Author: Alan Coopersmith Date: Mon Oct 17 00:40:28 2005 +0000 Put files in $(prefix)/lib/X11/xdm to match monolith install locations commit 82d152fba78e1c34b62b426a7854efd0b116afdd Author: Donnie Berkholz Date: Fri Oct 14 18:42:17 2005 +0000 Add another set of brackets around DEFAULTVT's empty default setting so it isn't treated as a command. commit 8ae6b815fc2641e48f994260ad817010116a1ec9 Author: Kevin E Martin Date: Tue Oct 4 23:45:46 2005 +0000 Use CLEANFILES for all generated files commit 3d9c1086b712ea62717c34e83d31efa3988dfc08 Author: Alan Coopersmith Date: Mon Oct 3 17:36:09 2005 +0000 Bug #3891 xdm build failure: IN6_IS_ADDR_LOOPBACK undefined (David Schleef) commit 960be79d2f246edc3b0d2b571c5ed44edbc07276 Author: Alan Coopersmith Date: Sun Oct 2 19:44:42 2005 +0000 Add Chooser app-defaults file to app/xdm commit 51a6b1de8beeb33858d3e8eb151cfad004a62ef8 Author: Kristian Høgsberg Date: Wed Sep 28 21:13:12 2005 +0000 Add Xservers.fs. commit 92864cfde7de9b5d9cf8894abeb7a972ea35d2a0 Author: Alan Coopersmith Date: Sun Aug 28 22:46:07 2005 +0000 Add comment to configure.ac explaining error: possibly undefined macro: AC_DEFINE message that some users were seeing, thanks to diagnosis from Stepan Kasal on the autoconf@gnu.org mailing list: dnl If you're looking here because you got a message that said dnl 'error: possibly undefined macro: AC_DEFINE', the source of dnl your problem is not here. You need to upgrade to pkgconfig 0.18 dnl or later to get an updated pkg.m4 with PKG_CHECK_EXISTS defined. dnl See http://www.mail-archive.com/autoconf@gnu.org/msg13413.html commit e0187570bd3efd7b61ccc41dbc21d0840ee82260 Author: Alan Coopersmith Date: Sat Aug 27 17:06:16 2005 +0000 Fixes for config files built via cpp commit 6bdf59b8f4fa96e5d85aafc87af57513794cb43e Author: Daniel Stone Date: Tue Aug 23 07:07:57 2005 +0000 Actually generate Xservers.ws from .cpp, and make build objdir != srcdir safe. commit d778b237aab11cfa4ac8d50587f045d8a0497b9a Author: Daniel Stone Date: Tue Aug 23 06:53:53 2005 +0000 Actually generate Xservers.ws from .cpp, and make build objdir != srcdir safe. commit 6a9a224cf84913f4dc9b87d59fac6594226e5b7e Author: Alan Coopersmith Date: Fri Aug 19 04:26:04 2005 +0000 Add #ifdef HAVE_CONFIG_H/#include "config.h" since "dm.h" is included too late. commit 91a45fdfd505233d8624f2664ffdf188d96549e4 Author: Adam Jackson Date: Wed Aug 17 20:35:09 2005 +0000 Fix EXTRA_DIST to point to a real variable. Bump to 0.99.1. commit 0f0954a36a9a71b9a98fb9a251dfc8ef4f815bed Author: Alan Coopersmith Date: Wed Aug 17 05:11:04 2005 +0000 Define USESHADOW if getspnam() is available Define USE_XINERAMA if pkg-config finds xinerama module Fix XDM_LIBS settings by various options commit 1abcef080aa3bd268a496c81b965d2db1086112e Author: Alan Coopersmith Date: Tue Aug 16 02:21:37 2005 +0000 Fix quoting on BINDIR definition for xdmshell commit e130f52f3b5f70f8cb478a2f64be2cd0c1fc553f Author: Alan Coopersmith Date: Tue Aug 16 01:19:40 2005 +0000 Convert cpp substitutions from __projectroot__/... to XDMDIR and BINDIR so they get correct pathnames in both modular & monolithic trees. commit 6b2d39036681c603f74bdd63f62198fbcdaae98f Author: Alan Coopersmith Date: Mon Aug 15 23:08:42 2005 +0000 Install xdm config files & man page Convert many more Imakefile checks into autoconf checks for xdm commit 7cd1bfa8acde5b494960c0b7e5b97abd89121545 Author: Alan Coopersmith Date: Sat Aug 13 02:46:59 2005 +0000 Install chooser in $(libdir)/xdm, not $(bindir) commit 6ae3766444c62ee920b94807ac514d1003ca4fee Author: Daniel Stone Date: Wed Aug 10 11:17:06 2005 +0000 Add build system for sessreg, broken out from xdm. commit 23b64bbec8561ea707633f4e73ec8e1616e48c8f Author: Adam Jackson Date: Wed Aug 3 04:14:23 2005 +0000 General fix: need to pull in more xtrans macros to get UNIXCONN etc defined OSX fixes: Define __DARWIN__, workaround some lastlog breakage. commit fbeae50b9153d45afa90df2b540141b74a436594 Author: Kevin E Martin Date: Fri Jul 29 21:22:31 2005 +0000 Various changes preparing packages for RC0: - Verify and update package version numbers as needed - Implement versioning scheme - Change bug address to point to bugzilla bug entry form - Disable loadable i18n in libX11 by default (use --enable-loadable-i18n to reenable it) - Fix makedepend to use pkgconfig and pass distcheck - Update build script to build macros first - Update modular Xorg version commit f07aa24d8eb865b4b15fdb0c059e70ab437a97f9 Author: Kevin E Martin Date: Thu Jul 28 01:10:49 2005 +0000 Add -D_XOPEN_SOURCE for Linux commit ac5184384d6347ea97da5cc7f85e9687ff060641 Author: Søren Sandmann Pedersen Date: Wed Jul 27 22:37:02 2005 +0000 Add XPROTO_CFLAGS to XDM_CFLAGS and CHOOSER_CFLAGS, also add _BSD_SOURCE to CHOOSER_FLAGS commit b92f8751058bf2bc94967b84f71c4c88a5f007df Author: Alan Coopersmith Date: Thu Jul 14 22:58:25 2005 +0000 Set HAS_VFORK if autoconf has set HAVE_WORKING_VFORK. Add #include "config.h" for modularization commit e3b9c2dfffb74fe0bb96c21c198b8f08dfff65f0 Author: Alan Coopersmith Date: Thu Jul 14 22:55:17 2005 +0000 Makefile.am: - Remove hardcoded definitions of _XOPEN_SOURCE, _POSIX_SOURCE, & _BSD_SOURCE configure.ac: - Use xtrans.m4 macros for IPv6 & SecureRPC support - Add PAM support - Add checks for vfork & mkstemp functions - Add libXdmcp to CHOOSER_LIBS commit 90b6e7d98567f77981adca5c2b9acc71d07f1442 Author: Søren Sandmann Pedersen Date: Fri Jul 8 20:45:03 2005 +0000 Add build system for xdm commit ac796dbe8d2877d479cb25397e2982b9e73b87ad Author: Alan Coopersmith Date: Tue Jul 5 18:52:33 2005 +0000 Bugzilla #2901 Patch #2317 This patch fixes several problems arising if xdm is compiled with IPv6 support, but the (linux) kernel does not support IPv6. (Peter Breitenlohner) commit 13b06d4e40a4d8a309b97dbab13cd6ac6aa469ad Author: Adam Jackson Date: Mon Jun 20 02:59:16 2005 +0000 Bug #2959: Make sure displays other than :0 get entries in utmp when started from xdm. (Tim Waugh) commit f890eac42449a34b258128749075220f860421c3 Author: Kean Johnson Date: Fri Jun 10 06:54:09 2005 +0000 file Xsession.cpp was initially added on branch sco_port_update. commit 9ab8ed5d49559eed0c7357c1a390bcd08b217d7a Author: Alan Coopersmith Date: Tue May 24 00:10:17 2005 +0000 Bugzilla #2165 Patches #1599 & 2754 XDM Chooser enhancements: scrollwheel, no mouse (Thomas Reifferscheid) commit dd32476e8b55a0c191376d61918e78a61d76ae43 Author: Matthieu Herrb Date: Wed Dec 15 20:49:08 2004 +0000 Remove unused define. commit 7a776dd5a49283ddb29c37eed565b7bd86a5ad8a Author: Matthieu Herrb Date: Thu Nov 11 15:44:31 2004 +0000 update shared lib revisions on OpenBSD (Bug #1828). update references to xf86site.def in comments (Bug #1827). fix kbd driver for wskbd protocol and pure wscons console driver (Bug #1825). don't add '-4' to generated default file name (bug #1826). typo in resource name (XFree86 bug #1300, X.org bug #1825) commit e58e367fd2a7d5e395cee23cfab6716219c74f67 Author: Matthieu Herrb Date: Thu Oct 21 06:03:13 2004 +0000 programs/xdm/greeter/verify.c Make BSDAUTH able to use non-default login classes. (Bugzilla #1676, Pierre Lalet). commit 40a8dac56de796db130b53dc1b01ea7421d0bf93 Author: Alan Coopersmith Date: Sat Aug 7 19:22:01 2004 +0000 Check to see if array->data is NULL before we dereference it, instead of after. (Prevents segfault when array->data is initialized to NULL, but array->length is not set to 0.) Always initialize both data & length in ARRAYs. commit 0f92f0f76b812a29bbb748e7588a7208be4c30e2 Author: Matthieu Herrb Date: Mon Jul 26 22:56:33 2004 +0000 Fix log file location in manual page. commit 616e67f2b69018a7c6ffd91f1742ece51c4c5f78 Author: Eric Anholt Date: Tue Jul 6 00:44:39 2004 +0000 XFree86 bugzilla #1376: xdm opens random tcp sockets "Even when DisplayManager.requestPort is set to 0, xdm will open a chooserFd tcp socket on all interfaces. This apparently cannot be disabled by configuration and presents a possible security risk. Older versions of xdm/socket.c appear to have checked and aborted if request_port == 0, but the current one does not..." commit c5072fb61a23d4b4063d9c2f6043c23ff200af1b Author: Egbert Eich Date: Mon May 24 19:05:01 2004 +0000 Muffle compiler warnings. fix option name in log message. improve debugging messages. commit 1a5767483ccfb5e95555ff9bed0a1ec5456be725 Author: Alan Coopersmith Date: Sat Apr 24 23:28:17 2004 +0000 xc/programs/xdm/greeter/verify.c Fix typo in Solaris console restriction code (Xfree() -> XFree()) xc/programs/xdm/greeter/Imakefile Link with PamLibraries if building with PAM support commit ec8b11f4b1ea888e28d71ee6f3903933d73aa65d Author: Egbert Eich Date: Fri Apr 23 19:54:43 2004 +0000 Merging XORG-CURRENT into trunk commit 37f2b9991615b9f440c08c15457c54ee69f27f38 Author: Keith Packard Date: Sat Mar 27 01:44:18 2004 +0000 file xorg-bw.xpm was initially added on branch XORG-RELEASE-1-TM. commit a6bfe9be2718bf7eb78ec4b7c0f8f32ddff9d5ab Author: Keith Packard Date: Sat Mar 27 01:44:18 2004 +0000 file xorg.xpm was initially added on branch XORG-RELEASE-1-TM. commit 69a0d00505815453ed192d9ce8da11ad1449d79b Author: Egbert Eich Date: Sun Mar 14 08:35:13 2004 +0000 Importing vendor version xf86-4_4_99_1 on Sun Mar 14 00:26:39 PST 2004 commit 819eb99db26dc93c189170ca00f268463c1f13ba Author: Egbert Eich Date: Wed Mar 3 12:13:00 2004 +0000 Importing vendor version xf86-4_4_0 on Wed Mar 3 04:09:24 PST 2004 commit 71d3a63e7fb725820d68fae4acc4b8868ea7e95d Author: Egbert Eich Date: Thu Feb 26 13:36:17 2004 +0000 readding XFree86's cvs IDs commit aaa7fe57361c3df1dc35775fa9610b16755d1d02 Author: Egbert Eich Date: Thu Feb 26 09:24:04 2004 +0000 Importing vendor version xf86-4_3_99_903 on Wed Feb 26 01:21:00 PST 2004 commit 102dcbe36ca6c5ef6c8efcfbf6ce6fa3542142ec Author: Egbert Eich Date: Thu Jan 29 08:09:07 2004 +0000 Importing vendor version xf86-012804-2330 on Thu Jan 29 00:06:33 PST 2004 commit 0bd68eefddac98eaebb353dce62971a34a565842 Author: Kaleb Keithley Date: Fri Dec 19 20:55:50 2003 +0000 XFree86 4.3.99.902 (RC 2) commit 450fda6015f1799648ff7da87fdb2c46d42415f8 Author: Kaleb Keithley Date: Thu Dec 4 22:03:47 2003 +0000 XFree86 4.3.99.901 (RC 1) commit ca56bbdb0d398371332467534deaefdb77883bd7 Author: Kaleb Keithley Date: Tue Nov 25 19:29:12 2003 +0000 XFree86 4.3.99.16 Bring the tree up to date for the Cygwin folks commit 19bd1c5e3910088ac0e92ca005427192a223c8a0 Author: Kaleb Keithley Date: Tue Nov 25 19:29:11 2003 +0000 Initial revision commit 6c29c43354706a933c0bc73a9c800bdfd1a9a827 Author: Kaleb Keithley Date: Fri Nov 14 16:49:22 2003 +0000 XFree86 4.3.0.1 commit fa5d4a38a4dae7f24cdf3b8650dd931294c0fdc6 Author: Kaleb Keithley Date: Fri Nov 14 16:49:22 2003 +0000 Initial revision commit df3e1beed5bbb631975127133464b7e24fc38497 Author: Kaleb Keithley Date: Fri Nov 14 15:54:53 2003 +0000 R6.6 is the Xorg base-line